Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Selected Server in the Search tab when there is only the primary server connected #437

Closed
Don-Isdale opened this issue Nov 27, 2024 · 1 comment
Assignees

Comments

@Don-Isdale
Copy link
Collaborator

Don-Isdale commented Nov 27, 2024

This sub-issue is part of #431.


Introduction

This is related to issue 'Make the Datasources component less prominent because it is only used by advanced users ', and is easier to resolve :

In the Search tab there is 'Selected Server', and if there is only 1 datasource then this can be hidden, and when there are multiple datasources it can be displayed. The users who access multiple datasources are more advanced, and won't be confused by this display.

@Don-Isdale Don-Isdale self-assigned this Nov 27, 2024
Don-Isdale added a commit that referenced this issue Nov 28, 2024
… server connected

Closes #437.
select-server.hbs : use this. prefix for component attribute .servers, part of framework upgrade #370.
left-panel.js : alias multipleServers because its basis may change; for hiding Panel::SelectedServer.
api-server.js : featuresCountAllTaskInstance() : call to getBlocksTask / getBlocksLimits : change param blockIds from [] to undefined, i.e. default to all blocks;  passing [] was an error in 126a15a which added this function.
api-servers.js : add multipleServersCP(), which enables panel/left-panel.hbs to update whereas using multipleServers does not.
left-panel.hbs : hide Panel::SelectedServer if not multipleServers.
@Don-Isdale
Copy link
Collaborator Author

Changes implemented

b550d0d Hide Selected Server in the Search tab when there is only the primary server connected


Tested OK on local

Screenshot from 2024-11-28 19-28-40
Screenshot from 2024-11-28 19-27-29
Screenshot from 2024-11-28 14-59-12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant