Standardized locale names #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thanks. I'd suggest that we consider removing some of the cases where the language name is mentioned in order to decrease the maintenance on this kind of thing, in cases where the language name doesn't really add anything useful -- the comments at the top of the files come to mind. |
|
Thanks for merging. I think this was rather a one-time operation, also no manual editing involved when checking/fixing. Having the language name in the file (comment) can be helpful. But I have no strong feelings about it. |
|
I suspect we're going to continue getting new translation contributions that need this correction too -- but as long as they get corrected on the way in, we'll stay consistent. No strong feelings either so let's leave it as is for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All locales (translations) are now named in their language. Following https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes.
This also addresses #765.