pkp/pkp-lib#6998 Don't allow mixed type for query param #10711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taslangraham
force-pushed
the
i6998-main
branch
2 times, most recently
from
5a68f7c to
a7c4103
Compare
asmecher
requested changes
Dec 16, 2024
There was a problem hiding this comment.
@taslangraham, after these changes, is the Collector::UNASSIGNED constant unused? If so, please remove it from the class.
taslangraham
force-pushed
the
i6998-main
branch
3 times, most recently
from
b92b121 to
7144d53
Compare
taslangraham
force-pushed
the
i6998-main
branch
from
7144d53 to
88eeb2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6998