Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Single-file upload component #988

Closed
NateWr opened this issue Dec 21, 2015 · 5 comments
Closed

[UI] Single-file upload component #988

NateWr opened this issue Dec 21, 2015 · 5 comments
Assignees
@NateWr
Milestone
OMP 1.2

Comments

@NateWr
Copy link
Contributor

NateWr commented Dec 21, 2015

Our upload component is large and geared towards multiple file uploads. But it's only ever used for uploading one file at a time. Using the plupload API it should be fairly easy to create an upload component that is more intuitive for single-file uploads.

This will only be a first step towards improvement of the submission process (see #975).
@NateWr NateWr self-assigned this Dec 21, 2015
@NateWr NateWr added this to the OMP 1.2 milestone Dec 21, 2015
@NateWr NateWr mentioned this issue Dec 21, 2015
Closed
7 tasks
@NateWr
Copy link
Contributor Author

NateWr commented Dec 21, 2015

Note for later: it might be nice to remove the "is this a revision" selection option in file upload during submission. It's only relevant later anyway.

@NateWr
Copy link
Contributor Author

NateWr commented Feb 22, 2016

PRs
#1171
pkp/omp#222
pkp/ojs#756

(edited the OMP PR)

@asmecher
Copy link
Member

The tests are complaining, both the validation and build phases. Did you want me to take a look at that, @NateWr? See e.g. https://travis-ci.org/pkp/omp/builds/110967289

asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@NateWr @asmecher
pkp#988 Basic working version of new file uploader
f090d86
asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@NateWr @asmecher
pkp#988 Clean up files removed during the upload process
d2ac5eb
asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@NateWr @asmecher
pkp#988 Only show the file uploader when genre/revision files selected
516d389
asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@NateWr @asmecher
pkp#988 Handle upload errors properly
71a2272
asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@NateWr @asmecher
pkp#988 Move uploader strings into common.xml
8e5652e
asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@NateWr @asmecher
pkp#988 Fix image and css uploaders and add filetype filters
19334b4
asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@NateWr @asmecher
pkp#988 Fix profile image upload error handling
f1b4185
asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@NateWr @asmecher
pkp#988 Remove unused user import template file
4b51339
asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@NateWr @asmecher
pkp#988 Remove unused file upload note form template
c228603
asmecher pushed a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@NateWr @asmecher
pkp#988 Remove deprecated hideClose parameter for modals
69df129
asmecher added a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@asmecher
pkp#988 Composer lockfile update
efc2676
asmecher added a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@asmecher
pkp#988 Fix file upload tests
46c2b84
asmecher added a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@asmecher
pkp#988 Add plupload externs
e14904a
asmecher added a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@asmecher
pkp#988 Add plupload externs
84a8c6c
asmecher added a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@asmecher
pkp#988 JS linting
76ec4b5
asmecher added a commit to asmecher/omp that referenced this issue Feb 22, 2016
@asmecher
pkp/pkp-lib#988 JS linting
520e7e9
asmecher added a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@asmecher
pkp#988 JS linting
47c1095
asmecher added a commit to asmecher/omp that referenced this issue Feb 22, 2016
@asmecher
pkp/pkp-lib#988 JS linting
5751a79
asmecher added a commit to asmecher/pkp-lib that referenced this issue Feb 22, 2016
@asmecher
pkp#988 JS linting/compile fixes
909e2e4
asmecher added a commit to asmecher/omp that referenced this issue Feb 22, 2016
@asmecher
pkp/pkp-lib#988 JS linting
f6ce296
asmecher added a commit to asmecher/omp that referenced this issue Feb 22, 2016
@asmecher
pkp/pkp-lib#988 Submodule update ##asmecher/i988_single_file_uploader…
254be72 
…_3##
asmecher added a commit that referenced this issue Feb 22, 2016
@asmecher
Merge pull request #1176 from asmecher/i988_single_file_uploader_3
4d4762c 
#988 Streamline plupload controls
asmecher added a commit to pkp/omp that referenced this issue Feb 22, 2016
@asmecher
Merge pull request #223 from asmecher/i988_single_file_uploader_2
49091aa 
pkp/pkp-lib#988 Streamline plupload controls
asmecher pushed a commit to asmecher/ojs that referenced this issue Feb 22, 2016
@NateWr @asmecher
pkp/pkp-lib#988 Support the new single file upload component
163bb03
asmecher pushed a commit to asmecher/ojs that referenced this issue Feb 22, 2016
@NateWr @asmecher
pkp/pkp-lib#988 Submodule update
3661b69
asmecher pushed a commit to asmecher/ojs that referenced this issue Feb 23, 2016
@NateWr @asmecher
pkp/pkp-lib#988 Support the new single file upload component
c06f070
asmecher added a commit to asmecher/ojs that referenced this issue Feb 23, 2016
@asmecher
pkp/pkp-lib#988 Fix import test selector for new uploader
455f75d
asmecher pushed a commit to asmecher/ojs that referenced this issue Feb 23, 2016
@NateWr @asmecher
pkp/pkp-lib#988 Submodule update
6c23ef1
asmecher added a commit to asmecher/lensGalley that referenced this issue Feb 23, 2016
@asmecher
pkp/pkp-lib#988 Move to improved plupload control
2bf80ef
asmecher added a commit to asmecher/ojs that referenced this issue Feb 23, 2016
@asmecher
pkp/pkp-lib#988 Fix test in lens galley plugin
b3e0399
asmecher pushed a commit to asmecher/ojs that referenced this issue Feb 23, 2016
@NateWr @asmecher
pkp/pkp-lib#988 Submodule update
6b68cca
asmecher added a commit that referenced this issue Feb 23, 2016
@asmecher
#988 Remove functional submission test
198ada2
asmecher added a commit to asmecher/ojs that referenced this issue Feb 23, 2016
@asmecher
pkp/pkp-lib#988 Remove functional submission test
f6f18d8
asmecher pushed a commit to asmecher/ojs that referenced this issue Feb 23, 2016
@NateWr @asmecher
pkp/pkp-lib#988 Submodule update
ae979e3
asmecher pushed a commit to asmecher/ojs that referenced this issue Feb 23, 2016
@NateWr @asmecher
pkp/pkp-lib#988 Support the new single file upload component
0b1bd44
asmecher added a commit to asmecher/ojs that referenced this issue Feb 23, 2016
@asmecher
pkp/pkp-lib#988 Fix import test selector for new uploader
bdb7c93
asmecher added a commit to asmecher/ojs that referenced this issue Feb 23, 2016
@asmecher
pkp/pkp-lib#988 Fix test in lens galley plugin
6df1209
asmecher added a commit to asmecher/ojs that referenced this issue Feb 23, 2016
@asmecher
pkp/pkp-lib#988 Remove functional submission test
d59571b
asmecher pushed a commit to asmecher/ojs that referenced this issue Feb 23, 2016
@NateWr @asmecher
pkp/pkp-lib#988 Submodule update
e9060be
asmecher added a commit to pkp/ojs that referenced this issue Feb 23, 2016
@asmecher
Merge pull request #757 from asmecher/i988_single_file_uploader
4e2b1d8 
pkp/pkp-lib#988 Streamline plupload controls
@asmecher
Copy link
Member

Everything merged, tests fixed. Thanks, @NateWr!

@NateWr
Copy link
Contributor Author

NateWr commented Feb 23, 2016

Thanks for the cleanup @asmecher!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NateWr NateWr

Labels
None yet
Projects
None yet
Milestone
OMP 1.2
Development

No branches or pull requests
2 participants
@asmecher @NateWr