Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The assignedTo parameter in the REST API should not mix types #6998

Closed
NateWr opened this issue Apr 27, 2021 · 7 comments
Closed

The assignedTo parameter in the REST API should not mix types #6998

NateWr opened this issue Apr 27, 2021 · 7 comments
Assignees
@pkp-dev-workflow
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.5.0 LTS

Comments

@NateWr
Copy link
Contributor

NateWr commented Apr 27, 2021

The assignedTo query parameter in the /submissions and /_submissions endpoints accepts an array of user IDs or -1 to get unassigned submissions. This query parameter shouldn't mix types.

Introduce a new query parameter, isUnassigned, to get unassigned submissions.
@NateWr NateWr added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Apr 27, 2021
@NateWr NateWr added this to the OJS/OMP/OPS 3.4 milestone Apr 27, 2021
@NateWr NateWr self-assigned this Apr 27, 2021
@NateWr NateWr moved this to Backlog in Editorial Workflow Jul 20, 2022
@NateWr NateWr moved this from Backlog to Todo in Editorial Workflow Jul 20, 2022
@NateWr NateWr modified the milestones: 3.4, 3.4.x Jan 17, 2023
@NateWr NateWr removed their assignment Jun 5, 2023
@asmecher asmecher modified the milestones: 3.4.0-x, 3.5.0 LTS Feb 22, 2024
@asmecher
Copy link
Member

Rescheduling for 3.5.0 -- where this may already be done as a result of the submission list work (and API changes).

@asmecher
Copy link
Member

asmecher commented Dec 7, 2024

Confirming that this still does need cleanup. The constant in question is UNASSIGNED (easily grepped).

@taslangraham
Copy link
Contributor

I can take a look at this @asmecher

taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Dec 16, 2024
@taslangraham
pkp#6998 Don't allow mixed type for query param
85353b0
@taslangraham taslangraham mentioned this issue Dec 16, 2024
Merged
taslangraham added a commit to taslangraham/ui-library that referenced this issue Dec 16, 2024
@taslangraham
pkp/pkp-lib#6998 Don't allow mixed type for assignedTo query param
0330cc9
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Dec 16, 2024
@taslangraham
pkp#6998 Don't allow mixed type for assignedTo query param
5a68f7c
@taslangraham taslangraham mentioned this issue Dec 16, 2024
Merged
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Dec 16, 2024
@taslangraham
pkp#6998 Don't allow mixed type for assignedTo query param
a7c4103
This was referenced Dec 16, 2024
Closed
Closed
Closed
@taslangraham
Copy link
Contributor

taslangraham commented Dec 16, 2024 •
edited
Loading

Ready for review @asmecher

pkp-lib: #10711
ui-lib: pkp/ui-library#466
submodule updates:
ojs - pkp/ojs#4560
ops - pkp/ops#828
omp - pkp/omp#1788

taslangraham added a commit to taslangraham/ui-library that referenced this issue Dec 16, 2024
@taslangraham
pkp/pkp-lib#6998 Don't allow mixed type for assignedTo query param
b0fdb1c
@asmecher
Copy link
Member

Thanks, @taslangraham, added a comment: #10711 (review)

taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Dec 18, 2024
@taslangraham
pkp#6998 Don't allow mixed type for assignedTo query param
772df67
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Dec 18, 2024
@taslangraham
pkp#6998 Don't allow mixed type for assignedTo query param
b92b121
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Dec 18, 2024
@taslangraham
pkp#6998 Don't allow mixed type for assignedTo query param
7144d53
taslangraham added a commit to taslangraham/ui-library that referenced this issue Dec 18, 2024
@taslangraham
pkp/pkp-lib#6998 Don't allow mixed type for assignedTo query param
b33d473
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Dec 18, 2024
@taslangraham
pkp#6998 Don't allow mixed type for assignedTo query param
88eeb2d
@taslangraham
Copy link
Contributor

@asmecher Thanks for the review. Updated and ready to go!

asmecher pushed a commit to pkp/ui-library that referenced this issue Dec 18, 2024
@taslangraham
pkp/pkp-lib#6998 Don't allow mixed type for assignedTo query param (#…
1641ced 
…466)
asmecher pushed a commit that referenced this issue Dec 18, 2024
@taslangraham
#6998 Don't allow mixed type for assignedTo query param (#10711)
abbdf4e
@asmecher
Copy link
Member

Nice and clean, thanks -- all merged (except I'll handle the submodules separately)!

@github-project-automation github-project-automation bot moved this from Todo to Done in Editorial Workflow Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkp-dev-workflow pkp-dev-workflow

Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
Editorial Workflow
Status: Done
Milestone
3.5.0 LTS
Development

No branches or pull requests
4 participants
@asmecher @NateWr @taslangraham @pkp-dev-workflow