[OJS] Improve submission process

[NateWr]

This issue covers improvements to be made to the submission process. This includes improving how users discover and initiate an attempt to submit, the registration process, and the actual submission flow.

An initial comment: #975 (comment)

The initial submission flow is disorienting because users have to first learn that they have to register and then once registered they get dumped in a very different-looking backend display.
...
Create a frontend landing page for a completed registration. The page should say prominently "Thanks for registering with the Journal/Press of ..." and followed by a list of actions: "Make a Submission", "Complete Profile". Only then should it jump to the backend. This landing page could be used for logging in too, and include other actions based on user role, eg: "View assigned submissions" for reviewers.

In addition, a review of the submission process threw up a number of smaller improvements that could be made.

The following is a complete list of tasks intended for completion for OJS 3.0:

• Display more prominent submissions button on the frontend. Create a block plugin to display a submissions button  #1717
• Create a login/registration flow which takes the user directly from login/registration to the submission workflow, or provides a landing page after login/registration that is native to the frontend and provides clear options for initiating a submission.
• Tidy up the copyright notice display at the top of the initial submission page
• During file upload there's a message to contact admin. Remove it. [OJS] Improve submission process #1528 (comment)
• Add contributor: "Denotes required field" indicator appears below the buttons
• Add contributor: asks for URL, ORCID, Suffix, Affiliation, Bio. Do contributors get accounts and can they be asked to enter this detail later? Should be kept but could maybe be tidied up a bit. [OJS] Improve submission process #1528 (comment)
• Confirmation: actually show a summary of their submission details. The more the merrier.
• ~~Complete: maybe a little style love for the "next steps" links.~~~
• ~~~Complete: should we add a link to the user's profile?~~~
• Copy Orcid ID from submission user to main author. [OJS] Improve submission process #1528 (comment)
• Improve clarity of file type selection. [OJS] Improve submission process #1528 (comment)

[asmecher]

During file upload there's a message to contact admin. Is this valuable or could it be removed?

This is probably just tradition. I don't suspect there's much utility in it.

Do contributors get accounts and can they be asked to enter this detail later?

Contributors do not get accounts automatically -- they'll have to register separately. Author records are maintained separately from user accounts, so ORCiDs will eventually be supported as a linking aid. Currently for other authors to be granted access they'll need to have a user account assigned through the participants grid, and this is done separately of the author list that's entered in the submission process for metadata purposes.

[NateWr]

Thanks @asmecher!

[crism]

ORCID should be copied (along with affiliation and nation) from submitting user to the main author; currently, it’s blank for the author, even if the user has set it in their profile. (See #1450.)

[NateWr]

I've implemented several of the key parts of this issue. When these PRs are merged this can be reassigned to OJS 3.0.1.

PRs:
#1716
pkp/ojs#968
pkp/omp#320

[asmecher]

Don't forget to assign to a reviewer per the rota :)

[NateWr]

Just waiting on the tests to fail. :)

[NateWr]

Um... apparently the tests can't find the logout link now?

https://travis-ci.org/pkp/omp/jobs/151269634#L834
https://travis-ci.org/pkp/omp/jobs/151269633#L829

[asmecher]

When the registration page finishes, the user has a session but it isn't associated with their user ID. Hence, when generating a page, no "Log Out" link. The redirect that used to be there at the end of registration would cause a full page reload, and on that page "Log Out" would be present.

[NateWr]

Hmm, the OJS tests seemed to pass:

https://travis-ci.org/pkp/ojs/builds/151269668

I wonder if the logout issue is unique to OMP because of #1715.

[asmecher]

@NateWr, have you walked through the registration process to see whether the Log Out link is presented in the right place? Or does this seem to be just a test issue?

[NateWr]

You were right. :) I've solved this by redirecting to a new /user/registrationComplete page on the frontend. Tests are running...

[NateWr]

@asmecher The tests are written assuming that registration dumps a user in the backend Submissions page, and navigating to a new submission is built into the createSubmission method. A couple options, which would you prefer:

1. I write a new test method for navigating from registration to a new submission, and modify the createSubmission method to start from the first step of the submission page.
2. Just modify createSubmission to assume it's starting from the registration page. A quick glance suggests it's only used immediately following a registration, but future tests might want to use it differently...

[asmecher]

#2 is OK, at least for now.

[NateWr]

The OJS tests are passing but OMP is failing, on code that should be identical. I believe this is happening because of #1715, but that should mean that all tests in OMP are failing. Maybe #1715 needs to be sorted out sooner rather than later?

[asmecher]

@NateWr, see #1715 (comment)

[NateWr]

I think this one fell off the train somewhere. I'll rebase and re-run tests tomorrow.

[NateWr]

I rebased these today for merge, but the OMP test is failing now. It appears to time out. I restarted it a couple times but it keeps timing out:

https://travis-ci.org/pkp/omp/jobs/154720368

Any thoughts?

[asmecher]

Are the PRs updated with your rebase? The OMP PR still looks like it has a merge conflict (can't be merged).

[NateWr]

Hmm, I re-re-based but now the tests are wigging out. The OJS is giving lots of output I've never seen before. The OMP test is still failing on the "Make a New Submission" string. I've manually walked through a registration and the "Make a New Submission" string is present.

Not sure what to do with this one...

[NateWr]

@asmecher Sorry, I'm running out of ideas on this one too.

The OJS test was passing, I've just rebased to fix a merge conflict so they're re-running.
The OMP tests for mysql and pgsql are failing at different places, but I can't see any particular reason for it.

[asmecher]

I see the tests are re-running here too -- I'll leave tabs open for when they finish. I may have to disappear for a while before that happens.

[asmecher]

Tests passed!

[NateWr]

@asmecher

Same here as #1739. OJS tests are passing but OMP tests are failing on AclarkSubmissionTest.

[NateWr]

PRs merged. Rescheduling the reset for post-3.0.

[ctgraham]

The ./user/registrationComplete introduced here is:

• Accessible outside of the workflow of registration
• Accessible following registration at a site context, but displaying a "make a new submission" link. (This introduces a "No [context] in context" error if followed. (cf. http://forum.pkp.sfu.ca/t/modifying-userregistercomplete-tpl/30720/1)

Should this be followed up here, or introduced as a new issue?

[NateWr]

@ctgraham Go ahead and make a new issue. It's likely to get lost in this issue. 👍

[NateWr]

Consolidating a related comment from a separate issue #975 (comment):

We could make primary or common file component types easier to select. The list is long and sorted alphabetically so you have to go digging for the "main file".

[NateWr]

There are only three items left, and I don't think any will make it into 3.1. The only exception is maybe:

"Copy Orcid ID from submission user to main author #1528 (comment)"

@asmecher I'm going to bump this to OJS 3.2 unless you want to split off the ORCID task for OJS 3.1.

[asmecher]

The ORCID change was trivial; I've just committed it.

[NateWr]

The remaining items in the checklist at the top are covered by #7191