3.5 - OJS - Redesign workflow - Copyediting notification isn't updating when copyeditor is assigned

[Tribunal33]

Describe the bug
After more investigation I'm not sure if this is an issue or expected. I noticed the bug when looking at default submissions in the copyediting stage such as #19 with Zita Woods as the author and Sarah Vogt as the copyeditor assigned. The status still requests to assign copyeditors. However, I believe I have found the root cause and when assigning an editor you must select the Permissions checkbox to "Allow this person to make changes to the publication...". I think there is a missing update trigger event state because this issue leads to another which I will try to outline below. The problem lies in that you can upload copyedits and the message will be stuck on "Awaiting Copyedits" until you make add another copyeditor with the checkbox selected.

Preconditions :
You can either start from a fresh submission or from the existing default dataset. I will start with default dataset and be logged in as dbarnes the Journal manager
To Reproduce
Steps to reproduce the behavior:

1. Select the submission Number 19 with author Woods or Number 3 author Kwantes
2. Observe that Participant Sarah Vogt is already assigned and notification message reads "Assign a copyeditor using Assign link..."
3. This is issue number 1 expectation would be that Message would detect there is a copyeditor and be "Awaiting Copyedits"
4. To find out the next the 2nd issue make sure you have added a proper copyeditor and the notification message is "Awaiting copyedits"
5. Now proceed to upload files in the copyedit section
6. Observe the notification message doesn't disappear like it supposed to in 3.4.0. You can upload more than one file and the message won't change.
7. You can add another copyeditor with the Permission checkbox selected and then the notfication will trigger the event and the message will hide since both requirements have been satisfied.
8. See error images below.

What application are you using?** OJS, version 3.5.0
Additional information
Please add any screenshots, logs or other information we can use to investigate this bug report.

[jardakotesovec]

@Tribunal33 What you are experiencing I think is combination of bug and having confusing notification.

As covered here - #10618 . Message says 'Assign Editor'.. but the code does not care about assigned editor, only whether copyediting discussion has started. Whether there was good reason to do it like this we don't know. With @Devika008 we agreed to address this in future in more comprehensive way and just stick with existing behaviour for 3.5.

You are right that the notification update was not triggered when copyedit file was uploaded. That should be now fixed on main branch.

Might be good to check against 3.3 - as for notifications we are just looking for regressions between old and new workflow page.

[Tribunal33]

Ok yes I see what you mean. This notification is misleading but I think I found the root trigger. When I added a copyeditor what triggered the change was the discussion option when adding a participant but the message isn't seen until a page refresh. I think there is a slight issue then still remaining but I believe it is consistent with 3.4 issue. Let me try to explain.

The discussion does not automatically refresh the notification component. It requires a screen refresh. If you add a discussion the notification message doesn't update even though the discussion area shows the message. I'm not sure how it validate the notifcation but I worry that once we upgrade journals then these notifications won't cycle through the states properly.

You can then refresh the page and the notification message will change correctly.

[Tribunal33]

Removed parent relationship. I think the original requirements and existing functionality in #10618 is working as expected. This would be an improvement to the notifications system. @jardakotesovec you can close out the original parent ticket 10618 now, but I will keep this one open to be fixed in the future. Moving to 3.6 milestone as I believe there is going to be improvements made to this system.