-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update testing dev docs to GitHub Actions #1251
Conversation
Hi @withanage, could you give this update to the testing docs a review? I've only changed parts referencing Travis, and haven't updated anything about Cypress (but if you see other things that need to be updated, let me know and I can try to incorporate those too). Here's the current outdated live version of the guide for reference. |
hi @kaitlinnewson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@withanage I've noticed that this "Download artifacts" link at the top of a PR when a test fails does not always appear consistently - do you know why that is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaitlinnewson actually, github should generate them automatically, do you have an example, where you could not see the Download link ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@withanage Nevermind, I think I see the confusion - this link to artifacts at the top only appears on the .../checks
page, but then does not appear if you click on a job (but can be accessed in the build log instead). For example:
- "Artifacts" link appears here: https://github.com/pkp/omp/pull/1710/checks
- "Artifacts" link does not appear here, once I click on the failed test: https://github.com/pkp/omp/actions/runs/11127681718/job/30920572138?pr=1710
@withanage Any additional feedback on these docs updates? |
@kaitlinnewson |
Update docs from Travis to GitHub Actions. Closes #1247.