after review: fix deprecated functions #4566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kaitlinnewson, could you please take a look at this PR -- today I found and hopefully fixed a few more things... |
| */ | ||
| public function createCreatorsNode($doc, $issue, $publication, $galley, $galleyFile, $publisher, $objectLocalePrecedence) | ||
| public function createCreatorsNode(DOMDocument $doc, Issue $issue, Publication $publication, Galley $galley, SubmissionFile $galleyFile, string $publisher, array $objectLocalePrecedence): DOMNode |
There was a problem hiding this comment.
In testing I encountered many cases of Argument #4 ($galley) must be of type PKP\galley\Galley, null given (and same for SubmissionFile) - should these be adjusted to take null values as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s. pkp/pkp-lib#10653
additionally fixed getStoredPubId() calls on submission object -- it should be publication