pkp/pkp-lib#9021 Consider galleys as objectsFileNamePart in DataCite …

[bozana]

…export XML file

s. pkp/pkp-lib#9021

[ewhanson]

Hey @bozana, these changes look good to me. 👍

I did come across a fatal error when exporting a Datacite DOI. I doubt it's related but am curious if you're running into it too.

Call to undefined method League\Flysystem\Filesystem::getSize()

Full stack trace...

[24-May-2023 00:07:43 UTC] Slim Application Error:
Type: Error
Message: Call to undefined method League\Flysystem\Filesystem::getSize()
File: /Users/erikhanson/pkp/www/public/ojsdev/plugins/generic/datacite/filter/DataciteXmlFilter.php
Line: 657
Trace: #0 /Users/erikhanson/pkp/www/public/ojsdev/plugins/generic/datacite/filter/DataciteXmlFilter.php(220): APP\plugins\generic\datacite\filter\DataciteXmlFilter->createSizesNode(Object(DOMDocument), Object(APP\issue\Issue), Object(APP\submission\Submission), Object(APP\publication\Publication), Object(PKP\galley\Galley), Object(PKP\submissionFile\SubmissionFile))
#1 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/classes/filter/Filter.php(499): APP\plugins\generic\datacite\filter\DataciteXmlFilter->process(Object(PKP\galley\Galley))
#2 /Users/erikhanson/pkp/www/public/ojsdev/classes/plugins/PubObjectsExportPlugin.php(482): PKP\filter\Filter->execute(Object(PKP\galley\Galley), true)
#3 /Users/erikhanson/pkp/www/public/ojsdev/plugins/generic/datacite/DataciteExportPlugin.php(199): APP\plugins\PubObjectsExportPlugin->exportXML(Object(PKP\galley\Galley), 'galley=>datacit...', Object(APP\journal\Journal), NULL, Array)
#4 /Users/erikhanson/pkp/www/public/ojsdev/plugins/generic/datacite/DatacitePlugin.php(115): APP\plugins\generic\datacite\DataciteExportPlugin->exportAsDownload(Object(APP\journal\Journal), Array, NULL, Array)
#5 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/api/v1/dois/PKPDoiHandler.php(417): APP\plugins\generic\datacite\DatacitePlugin->exportSubmissions(Array, Object(APP\journal\Journal))
#6 [internal function]: PKP\API\v1\dois\PKPDoiHandler->exportSubmissions(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Array)
#7 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php(40): call_user_func(Array, Object(Slim\Http\Request), Object(PKP\core\APIResponse), Array)
#8 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/Route.php(281): Slim\Handlers\Strategies\RequestResponse->__invoke(Array, Object(Slim\Http\Request), Object(PKP\core\APIResponse), Array)
#9 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(117): Slim\Route->__invoke(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#10 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/Route.php(268): Slim\Route->callMiddlewareStack(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#11 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/App.php(503): Slim\Route->run(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#12 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/classes/security/authorization/internal/ApiAuthorizationMiddleware.php(88): Slim\App->__invoke(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#13 [internal function]: PKP\security\authorization\internal\ApiAuthorizationMiddleware->__invoke(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Slim\App))
#14 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/DeferredCallable.php(57): call_user_func_array(Object(PKP\security\authorization\internal\ApiAuthorizationMiddleware), Array)
#15 [internal function]: Slim\DeferredCallable->__invoke(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Slim\App))
#16 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(70): call_user_func(Object(Slim\DeferredCallable), Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Slim\App))
#17 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/classes/security/authorization/internal/ApiCsrfMiddleware.php(55): Slim\App->Slim{closure}(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#18 [internal function]: PKP\security\authorization\internal\ApiCsrfMiddleware->__invoke(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#19 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/DeferredCallable.php(57): call_user_func_array(Object(PKP\security\authorization\internal\ApiCsrfMiddleware), Array)
#20 [internal function]: Slim\DeferredCallable->__invoke(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#21 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(70): call_user_func(Object(Slim\DeferredCallable), Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#22 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/classes/security/authorization/internal/ApiTokenDecodingMiddleware.php(143): Slim\App->Slim{closure}(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#23 [internal function]: PKP\security\authorization\internal\ApiTokenDecodingMiddleware->__invoke(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#24 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/DeferredCallable.php(57): call_user_func_array(Object(PKP\security\authorization\internal\ApiTokenDecodingMiddleware), Array)
#25 [internal function]: Slim\DeferredCallable->__invoke(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#26 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(70): call_user_func(Object(Slim\DeferredCallable), Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#27 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/classes/handler/APIHandler.php(81): Slim\App->Slim{closure}(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#28 [internal function]: PKP\handler\APIHandler->PKP\handler{closure}(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#29 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/DeferredCallable.php(57): call_user_func_array(Object(Closure), Array)
#30 [internal function]: Slim\DeferredCallable->__invoke(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#31 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(70): call_user_func(Object(Slim\DeferredCallable), Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#32 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/classes/handler/APIHandler.php(98): Slim\App->Slim{closure}(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#33 [internal function]: PKP\handler\APIHandler->PKP\handler{closure}(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#34 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/DeferredCallable.php(57): call_user_func_array(Object(Closure), Array)
#35 [internal function]: Slim\DeferredCallable->__invoke(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#36 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(70): call_user_func(Object(Slim\DeferredCallable), Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#37 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/classes/handler/APIHandler.php(103): Slim\App->Slim{closure}(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#38 [internal function]: PKP\handler\APIHandler->PKP\handler{closure}(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#39 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/DeferredCallable.php(57): call_user_func_array(Object(Closure), Array)
#40 [internal function]: Slim\DeferredCallable->__invoke(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#41 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(70): call_user_func(Object(Slim\DeferredCallable), Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#42 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(117): Slim\App->Slim{closure}(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#43 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/App.php(392): Slim\App->callMiddlewareStack(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#44 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/classes/handler/APIHandler.php(96): Slim\App->process(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#45 [internal function]: PKP\handler\APIHandler->PKP\handler{closure}(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#46 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/DeferredCallable.php(57): call_user_func_array(Object(Closure), Array)
#47 [internal function]: Slim\DeferredCallable->__invoke(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#48 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(70): call_user_func(Object(Slim\DeferredCallable), Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#49 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/classes/handler/APIHandler.php(103): Slim\App->Slim{closure}(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#50 [internal function]: PKP\handler\APIHandler->PKP\handler{closure}(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#51 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/DeferredCallable.php(57): call_user_func_array(Object(Closure), Array)
#52 [internal function]: Slim\DeferredCallable->__invoke(Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#53 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(70): call_user_func(Object(Slim\DeferredCallable), Object(Slim\Http\Request), Object(PKP\core\APIResponse), Object(Closure))
#54 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(117): Slim\App->Slim{closure}(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#55 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/App.php(392): Slim\App->callMiddlewareStack(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#56 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/lib/vendor/slim/slim/Slim/App.php(297): Slim\App->process(Object(Slim\Http\Request), Object(PKP\core\APIResponse))
#57 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/classes/core/APIRouter.php(110): Slim\App->run()
#58 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/classes/core/Dispatcher.php(166): PKP\core\APIRouter->route(Object(APP\core\Request))
#59 /Users/erikhanson/pkp/www/public/ojsdev/lib/pkp/classes/core/PKPApplication.php(373): PKP\core\Dispatcher->dispatch(Object(APP\core\Request))
#60 /Users/erikhanson/pkp/www/public/ojsdev/index.php(21): PKP\core\PKPApplication->execute()
#61 /Users/erikhanson/.composer/vendor/laravel/valet/server.php(110): require('/Users/erikhans...')
#62 {main}
View in rendered output by enabling the "displayErrorDetails" setting.

[ewhanson]

In case it's helpful: getSize() should exist per the Flysystem documentation so there's likely an error instantiating it somewhere along the way.

[bozana]

Hi @ewhanson, I found that error too and crated this PR for that: pkp/pkp-lib#9020...
I will then proceed with this change of file name too...
Thanks a lot!