Skip to content

Commit

Permalink
Merge pull request #968 from NateWr/i1528_submission_flow
Browse files Browse the repository at this point in the history
pkp/pkp-lib#1528 Improve submission flow
  • Loading branch information
NateWr authored Aug 31, 2016
2 parents 750088c + 5e8c2f9 commit 453f9ac
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 24 deletions.
2 changes: 1 addition & 1 deletion classes/submission/form/SubmissionSubmitStep1Form.inc.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function fetch($request) {

// Get section for this context
$sectionDao = DAORegistry::getDAO('SectionDAO');
$sectionOptions = array('0' => __('submission.submit.selectSection')) + $sectionDao->getSectionTitles($this->context->getId());
$sectionOptions = array('0' => '') + $sectionDao->getSectionTitles($this->context->getId());
$templateMgr->assign('sectionOptions', $sectionOptions);

return parent::fetch($request);
Expand Down
2 changes: 1 addition & 1 deletion lib/pkp
Submodule pkp updated 151 files
5 changes: 1 addition & 4 deletions locale/en_US/author.xml
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,8 @@
<message key="author.submissions.confirmDelete">Are you sure you want to delete this incomplete submission?</message>
<message key="author.submissions.viewStatus">View Status</message>
<message key="author.submissions.noSubmissions">No submissions.</message>
<message key="author.submit.howToSubmit"><![CDATA[Encountering difficulties? Contact <a href="mailto:{$supportEmail}">{$supportName}</a> for assistance ({$supportPhone}).]]></message>
<message key="author.submit.howToSubmitNoPhone"><![CDATA[Encountering difficulties? Contact <a href="mailto:{$supportEmail}">{$supportName}</a> for assistance.]]></message>
<message key="author.submit.journalSection">Journal Section</message>
<message key="author.submit.journalSectionDescription"><![CDATA[Select the appropriate section for this submission (see Sections and Policies in <a href="{$aboutUrl}" target="_new">About</a> the Journal).]]></message>
<message key="submission.submit.selectSection">Please select a section...</message>
<message key="author.submit.journalSectionDescription">Articles must be submitted to one of the journal's sections.</message>
<message key="author.submit.submissionLocale">Submission Language</message>
<message key="author.submit.submissionLocaleDescription">This journal accepts submissions in several languages. Choose the primary language of the submission from the pulldown below.</message>
<message key="author.submit.verifyChecklist">You must make sure all items in the submission checklist are satisfied before continuing.</message>
Expand Down
14 changes: 7 additions & 7 deletions locale/en_US/default.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@
<message key="default.journalSettings.checklist.fileFormat">The submission file is in OpenOffice, Microsoft Word, or RTF document file format.</message>
<message key="default.journalSettings.checklist.addressesLinked">Where available, URLs for the references have been provided.</message>
<message key="default.journalSettings.checklist.submissionAppearance">The text is single-spaced; uses a 12-point font; employs italics, rather than underlining (except with URL addresses); and all illustrations, figures, and tables are placed within the text at the appropriate points, rather than at the end.</message>
<message key="default.journalSettings.checklist.bibliographicRequirements"><![CDATA[The text adheres to the stylistic and bibliographic requirements outlined in the <a href="{$indexUrl}/{$journalPath}/about/submissions#authorGuidelines" target="_new">Author Guidelines</a>, which is found in About the Journal.]]></message>
<message key="default.journalSettings.checklist.bibliographicRequirements">The text adheres to the stylistic and bibliographic requirements outlined in the Author Guidelines.</message>
<message key="default.journalSettings.privacyStatement">The names and email addresses entered in this journal site will be used exclusively for the stated purposes of this journal and will not be made available for any other purpose or to any other party.</message>
<message key="default.journalSettings.openAccessPolicy">This journal provides immediate open access to its content on the principle that making research freely available to the public supports a greater global exchange of knowledge.</message>
<message key="default.journalSettings.authorSelfArchivePolicy">This journal permits and encourages authors to post items submitted to the journal on personal websites or institutional repositories both prior to and after publication, while providing bibliographic details that credit, if applicable, its publication in this journal.</message>
<message key="default.journalSettings.copyeditInstructions"><![CDATA[The copyediting stage is intended to improve the flow, clarity, grammar, wording, and formatting of the article. It represents the last chance for the author to make any substantial changes to the text because the next stage is restricted to typos and formatting corrections.
<message key="default.journalSettings.copyeditInstructions"><![CDATA[The copyediting stage is intended to improve the flow, clarity, grammar, wording, and formatting of the article. It represents the last chance for the author to make any substantial changes to the text because the next stage is restricted to typos and formatting corrections.
The file to be copyedited is in Word or .rtf format and therefore can easily be edited as a word processing document. The set of instructions displayed here proposes two approaches to copyediting. One is based on Microsoft Word's Track Changes feature and requires that the copy editor, editor, and author have access to this program. A second system, which is software independent, has been borrowed, with permission, from the Harvard Educational Review. The journal editor is in a position to modify these instructions, so suggestions can be made to improve the process for this journal.
Expand All @@ -43,7 +43,7 @@ The file to be copyedited is in Word or .rtf format and therefore can easily be
Under Tools in the menu bar, the feature Track Changes enables the copy editor to make insertions (text appears in color) and deletions (text appears crossed out in color or in the margins as deleted). The copy editor can posit queries to both the author (Author Queries) and to the editor (Editor Queries) by inserting these queries in square brackets. The copyedited version is then uploaded, and the editor is notified. The editor then reviews the text and notifies the author.
The editor and author should leave those changes with which they are satisfied. If further changes are necessary, the editor and author can make changes to the initial insertions or deletions, as well as make new insertions or deletions elsewhere in the text. Authors and editors should respond to each of the queries addressed to them, with responses placed inside the square brackets.
The editor and author should leave those changes with which they are satisfied. If further changes are necessary, the editor and author can make changes to the initial insertions or deletions, as well as make new insertions or deletions elsewhere in the text. Authors and editors should respond to each of the queries addressed to them, with responses placed inside the square brackets.
After the text has been reviewed by editor and author, the copy editor will make a final pass over the text accepting the changes in preparation for the layout and galley stage.
Expand Down Expand Up @@ -122,21 +122,21 @@ Please follow the following protocol for making electronic revisions to your man
<br />
<h4>For Formatting Errors</h4>
<p>Describe the location and nature of the problem in the Proofreading Corrections box after typing in the title "FORMATTING" as follows:</p>
<br />
<pre>3. FORMATTING
The numbers in Table 3 are not aligned in the third column.</pre>
<br />
<pre>4. FORMATTING
The paragraph that begins "This last topic..." is not indented.</pre>]]></message>

<message key="default.journalSettings.forReaders"><![CDATA[We encourage readers to sign up for the publishing notification service for this journal. Use the <a href="{$indexUrl}/{$journalPath}/user/register">Register</a> link at the top of the home page for the journal. This registration will result in the reader receiving the Table of Contents by email for each new issue of the journal. This list also allows the journal to claim a certain level of support or readership. See the journal's <a href="{$indexUrl}/{$journalPath}/about/submissions#privacyStatement">Privacy Statement</a>, which assures readers that their name and email address will not be used for other purposes.]]></message>
<message key="default.journalSettings.forAuthors"><![CDATA[Interested in submitting to this journal? We recommend that you review the <a href="{$indexUrl}/{$journalPath}/about">About the Journal</a> page for the journal's section policies, as well as the <a href="{$indexUrl}/{$journalPath}/about/submissions#authorGuidelines">Author Guidelines</a>. Authors need to <a href="{$indexUrl}/{$journalPath}/user/register">register</a> with the journal prior to submitting or, if already registered, can simply <a href="{$indexUrl}/index/login">log in</a> and begin the five-step process.]]></message>
<message key="default.journalSettings.forAuthors"><![CDATA[Interested in submitting to this journal? We recommend that you review the <a href="{$indexUrl}/{$journalPath}/about">About the Journal</a> page for the journal's section policies, as well as the <a href="{$indexUrl}/{$journalPath}/about/submissions#authorGuidelines">Author Guidelines</a>. Authors need to <a href="{$indexUrl}/{$journalPath}/user/register">register</a> with the journal prior to submitting or, if already registered, can simply <a href="{$indexUrl}/index/login">log in</a> and begin the five-step process.]]></message>
<message key="default.journalSettings.forLibrarians"><![CDATA[We encourage research librarians to list this journal among their library's electronic journal holdings. As well, it may be worth noting that this journal's open source publishing system is suitable for libraries to host for their faculty members to use with journals they are involved in editing (see <a href="http://pkp.sfu.ca/ojs">Open Journal Systems</a>).]]></message>
<message key="default.journalSettings.lockssLicense"><![CDATA[This journal utilizes the LOCKSS system to create a distributed archiving system among participating libraries and permits those libraries to create permanent archives of the journal for purposes of preservation and restoration. <a href="http://www.lockss.org/">More...</a>]]></message>
<message key="default.journalSettings.clockssLicense"><![CDATA[This journal utilizes the CLOCKSS system to create a distributed archiving system among participating libraries and permits those libraries to create permanent archives of the journal for purposes of preservation and restoration. <a href="http://clockss.org/">More...</a>]]></message>

<!-- Default settings for payment items. -->
<message key="default.journalSettings.submissionFee">Article Submission</message>
<message key="default.journalSettings.submissionFeeDescription">Authors are required to pay an Article Submission Fee as part of the submission process to contribute to review costs.</message>
Expand Down
6 changes: 4 additions & 2 deletions locale/en_US/locale.xml
Original file line number Diff line number Diff line change
Expand Up @@ -789,10 +789,12 @@ Active is how many reviews are currently being considered or underway.]]></messa
<message key="about.focusAndScope">Focus and Scope</message>
<message key="about.sectionPolicies">Section Policies</message>
<message key="about.submissions">Submissions</message>
<message key="about.onlineSubmissions">Online Submissions</message>
<message key="about.onlineSubmissions.login">Login</message>
<message key="about.onlineSubmissions.register">Register</message>
<message key="about.onlineSubmissions.registrationRequired">You must be registered and logged in to submit items and track current submissions. {$login} to an existing account or {$register} a new account.</message>
<message key="about.onlineSubmissions.registrationRequired">{$login} or {$register} to make a submission.</message>
<message key="about.onlineSubmissions.submissionActions">{$newSubmission} or {$viewSubmissions}.</message>
<message key="about.onlineSubmissions.newSubmission">Make a new submission</message>
<message key="about.onlineSubmissions.viewSubmissions">view your pending submissions</message>
<message key="about.authorGuidelines">Author Guidelines</message>
<message key="about.submissionPreparationChecklist">Submission Preparation Checklist</message>
<message key="about.submissionPreparationChecklist.description">As part of the submission process, authors are required to check off their submission's compliance with all of the following items, and submissions may be returned to authors that do not adhere to these guidelines.</message>
Expand Down
2 changes: 2 additions & 0 deletions locale/en_US/submission.xml
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,6 @@
<message key="submission.submit.form.contributorRoleRequired">Please select the contributor's role.</message>

<message key="submission.citationFormat.notFound">The requested citation format could not be retrieved.</message>

<message key="submission.metadataDescription">These specifications are based on the Dublin Core metadata set, an international standard used to describe journal content.</message>
</locale>
2 changes: 0 additions & 2 deletions locale/te_ST/locale.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2407,8 +2407,6 @@ Authors who publish with this journal agree to the following terms:
<message key="reviewer.competingInterests">Competing Interests</message>
<message key="author.competingInterests"><![CDATA[Competing interests <a target="_new" class="action" href="{$competingInterestGuidelinesUrl}">CI Policy</a>]]></message>
<message key="author.submit.startHereLink"><![CDATA[<a href="{$submitUrl}" class="action">Click here</a> to go to step one of the five-step submission process.]]></message>
<message key="author.submit.howToSubmit"><![CDATA[Encountering difficulties? Contact <a href="mailto:{$supportEmail}">{$supportName}</a> for assistance ({$supportPhone}).]]></message>
<message key="author.submit.howToSubmitNoPhone"><![CDATA[Encountering difficulties? Contact <a href="mailto:{$supportEmail}">{$supportName}</a> for assistance.]]></message>
<message key="author.submit.journalSectionDescription"><![CDATA[Select the appropriate section for this submission (see Sections and Policies in <a href="{$aboutUrl}" target="_new">About</a> the Journal).]]></message>
<message key="author.submit.reorderInstructions">Reorder authors to appear in the order they will be listed on publication.</message>
<message key="author.submit.submissionIndexingDescription">Provide terms for indexing the submission; separate terms with a semi-colon (term1; term2; term3).</message>
Expand Down
1 change: 1 addition & 0 deletions pages/user/index.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
//
case 'register':
case 'registerUser':
case 'registrationComplete':
case 'activateUser':
define('HANDLER_CLASS', 'RegistrationHandler');
import('lib.pkp.pages.user.RegistrationHandler');
Expand Down
12 changes: 5 additions & 7 deletions templates/submission/form/section.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,10 @@
*
* Include section placement for submissions.
*}
{url|assign:"aboutUrl" router=$smarty.const.ROUTE_PAGE page="about" op="submissions"}
{if $readOnly}{* Bug #8379 *}
{assign var=sectionDescription value=""}
{else}
{translate|assign:sectionDescription key="author.submit.journalSectionDescription" aboutUrl=$aboutUrl}
{assign var=sectionDescription value=""}
{if !$readOnly}
{assign var=sectionDescription value="author.submit.journalSectionDescription"}
{/if}
{fbvFormSection label="section.section"|translate description=$sectionDescription translate=false}
{fbvElement type="select" id="sectionId" from=$sectionOptions selected=$sectionId translate=false disabled=$readOnly size=$fbvStyles.size.MEDIUM}
{fbvFormSection title="section.section" required=true}
{fbvElement type="select" id="sectionId" label=$sectionDescription from=$sectionOptions selected=$sectionId translate=false disabled=$readOnly size=$fbvStyles.size.MEDIUM}
{/fbvFormSection}

0 comments on commit 453f9ac

Please sign in to comment.