From 17ac82bfc4d5c10016cc8fb14c53d10e98c2d878 Mon Sep 17 00:00:00 2001
From: Alec Smecher <alec@smecher.bc.ca>
Date: Fri, 6 Dec 2024 17:54:57 -0800
Subject: [PATCH] Consistently escape issue identification

---
 templates/frontend/components/breadcrumbs_article.tpl | 2 +-
 templates/frontend/objects/article_details.tpl        | 2 +-
 templates/frontend/pages/indexJournal.tpl             | 2 +-
 templates/gateway/clockss.tpl                         | 2 +-
 templates/gateway/lockss.tpl                          | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/templates/frontend/components/breadcrumbs_article.tpl b/templates/frontend/components/breadcrumbs_article.tpl
index bcb19294442..805115bd600 100644
--- a/templates/frontend/components/breadcrumbs_article.tpl
+++ b/templates/frontend/components/breadcrumbs_article.tpl
@@ -32,7 +32,7 @@
 		{if $issue}
 			<li>
 				<a href="{url page="issue" op="view" path=$issue->getBestIssueId()}">
-					{$issue->getIssueIdentification()}
+					{$issue->getIssueIdentification()|escape}
 				</a>
 				<span class="separator">{translate key="navigation.breadcrumbSeparator"}</span>
 			</li>
diff --git a/templates/frontend/objects/article_details.tpl b/templates/frontend/objects/article_details.tpl
index 0c5b51e4b0a..bd23d265ad8 100755
--- a/templates/frontend/objects/article_details.tpl
+++ b/templates/frontend/objects/article_details.tpl
@@ -371,7 +371,7 @@
 							</h2>
 							<div class="value">
 								<a class="title" href="{url page="issue" op="view" path=$issue->getBestIssueId()}">
-									{$issue->getIssueIdentification()}
+									{$issue->getIssueIdentification()|escape}
 								</a>
 							</div>
 						</section>
diff --git a/templates/frontend/pages/indexJournal.tpl b/templates/frontend/pages/indexJournal.tpl
index 6fbb3cf68e5..1cb8816d29f 100644
--- a/templates/frontend/pages/indexJournal.tpl
+++ b/templates/frontend/pages/indexJournal.tpl
@@ -53,7 +53,7 @@
 				{translate key="journal.currentIssue"}
 			</h2>
 			<div class="current_issue_title">
-				{$issue->getIssueIdentification()|strip_unsafe_html}
+				{$issue->getIssueIdentification()|escape}
 			</div>
 			{include file="frontend/objects/issue_toc.tpl" heading="h3"}
 			<a href="{url router=PKP\core\PKPApplication::ROUTE_PAGE page="issue" op="archive"}" class="read_more">
diff --git a/templates/gateway/clockss.tpl b/templates/gateway/clockss.tpl
index 56e06980d14..71ad23fb7ba 100644
--- a/templates/gateway/clockss.tpl
+++ b/templates/gateway/clockss.tpl
@@ -31,7 +31,7 @@
 
 <ul>
 {foreach from=$issues item=issue}
-	<li><a href="{url page="issue" op="view" path=$issue->getBestIssueId()}">{$issue->getIssueIdentification()|strip_unsafe_html|nl2br}</a></li>
+	<li><a href="{url page="issue" op="view" path=$issue->getBestIssueId()}">{$issue->getIssueIdentification()|escape}</a></li>
 {/foreach}
 </ul>
 
diff --git a/templates/gateway/lockss.tpl b/templates/gateway/lockss.tpl
index 033120e7ad7..7a2cc960931 100644
--- a/templates/gateway/lockss.tpl
+++ b/templates/gateway/lockss.tpl
@@ -31,7 +31,7 @@
 
 <ul>
 {foreach from=$issues item=issue}
-	<li><a href="{url page="issue" op="view" path=$issue->getBestIssueId()}">{$issue->getIssueIdentification()|strip_unsafe_html|nl2br}</a></li>
+	<li><a href="{url page="issue" op="view" path=$issue->getBestIssueId()}">{$issue->getIssueIdentification()|escape}</a></li>
 {/foreach}
 </ul>