Consistently escape issue identification

pkp · Dec 7, 2024 · 17ac82b · 17ac82b
1 parent 89dc377
commit 17ac82b
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/templates/frontend/components/breadcrumbs_article.tpl b/templates/frontend/components/breadcrumbs_article.tpl
@@ -32,7 +32,7 @@
 		{if $issue}
 			<li>
 				<a href="{url page="issue" op="view" path=$issue->getBestIssueId()}">
-					{$issue->getIssueIdentification()}
+					{$issue->getIssueIdentification()|escape}
 				</a>
 				<span class="separator">{translate key="navigation.breadcrumbSeparator"}</span>
 			</li>

diff --git a/templates/frontend/objects/article_details.tpl b/templates/frontend/objects/article_details.tpl
@@ -371,7 +371,7 @@
 							</h2>
 							<div class="value">
 								<a class="title" href="{url page="issue" op="view" path=$issue->getBestIssueId()}">
-									{$issue->getIssueIdentification()}
+									{$issue->getIssueIdentification()|escape}
 								</a>
 							</div>
 						</section>

diff --git a/templates/frontend/pages/indexJournal.tpl b/templates/frontend/pages/indexJournal.tpl
@@ -53,7 +53,7 @@
 				{translate key="journal.currentIssue"}
 			</h2>
 			<div class="current_issue_title">
-				{$issue->getIssueIdentification()|strip_unsafe_html}
+				{$issue->getIssueIdentification()|escape}
 			</div>
 			{include file="frontend/objects/issue_toc.tpl" heading="h3"}
 			<a href="{url router=PKP\core\PKPApplication::ROUTE_PAGE page="issue" op="archive"}" class="read_more">

diff --git a/templates/gateway/clockss.tpl b/templates/gateway/clockss.tpl
@@ -31,7 +31,7 @@
 
 <ul>
 {foreach from=$issues item=issue}
-	<li><a href="{url page="issue" op="view" path=$issue->getBestIssueId()}">{$issue->getIssueIdentification()|strip_unsafe_html|nl2br}</a></li>
+	<li><a href="{url page="issue" op="view" path=$issue->getBestIssueId()}">{$issue->getIssueIdentification()|escape}</a></li>
 {/foreach}
 </ul>
 

diff --git a/templates/gateway/lockss.tpl b/templates/gateway/lockss.tpl
@@ -31,7 +31,7 @@
 
 <ul>
 {foreach from=$issues item=issue}
-	<li><a href="{url page="issue" op="view" path=$issue->getBestIssueId()}">{$issue->getIssueIdentification()|strip_unsafe_html|nl2br}</a></li>
+	<li><a href="{url page="issue" op="view" path=$issue->getBestIssueId()}">{$issue->getIssueIdentification()|escape}</a></li>
 {/foreach}
 </ul>