Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin doesn't allow editing official translation's empty strings #26

Open
alvgalrus opened this issue Sep 12, 2023 · 4 comments
Open

Comments

@alvgalrus
Copy link

alvgalrus commented Sep 12, 2023

Hello!

As the title says, the plugin doesn't allow editing empty translation strings, like this one in pkp-lib/locale/es/emails.po:

msgid "emails.footer.unsubscribe"
msgstr ""

I know, the best approach would be contributing untranslated strings, but in the meantime we need a fix for these tags being sent to the users now. As a quick fix I had to add them to the emails.po file but they'll be removed with the next update.

Also, I've checked the pkp-lib's Weblate project and currently there isn't a section for this emails.po file, the Spanish translation is shown as complete.

So the empty strings aren't shown in the UI for translation. May this option be added for future fixes?

Regards!

@asmecher
Copy link
Member

asmecher commented Jan 3, 2024

@alvgalrus, we recently added the emails.po file to Weblate -- I'm not sure how we managed to overlook that for so long! It's not the solution you proposed here, but is it enough to resolve your issue?

@alvgalrus
Copy link
Author

@asmecher Thank you for taking care of that mismatch in the files, I suppose it works for the time being!

@anasfanani
Copy link

anasfanani commented Sep 3, 2024

I had this issue also, my site show this in Indonesian language:

##admin.jobs.viewQueuedJobs##
##admin.jobs.totalCount##
##admin.jobs.list.id##	##admin.jobs.list.displayName##	##admin.jobs.list.queue##	##admin.jobs.list.attempts##	##admin.jobs.list.createdAt##

I see a lot of empty translations, it can help if there are empty translations, fallback to English.

Check with command msgfmt from gettext package:

root:~#msgfmt --verbose --statistics lib/pkp/locale/id/admin.po
lib/pkp/locale/id/admin.po: 91 translated messages, 156 untranslated messages.

I fill empty translation from en translation:

root:~#msgcat --use-first lib/pkp/locale/id/admin.po lib/pkp/locale/en/admin.po -o lib/pkp/locale/id/admin.po
root:~#msgfmt --verbose --statistics lib/pkp/locale/id/admin.po
lib/pkp/locale/id/admin.po: 256 translated messages, 1 untranslated message.

@asmecher
Copy link
Member

asmecher commented Sep 6, 2024

@anasfanani, we use Weblate for managing translations; see https://translate.pkp.sfu.ca/ for details. If you've got questions on this, it's probably best to ask on the support forum: https://forum.pkp.sfu.ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants