From ecf873ba91fb41b136686a699369966e423e33d5 Mon Sep 17 00:00:00 2001 From: Priyansh Kedia Date: Fri, 28 Jan 2022 13:03:30 +0530 Subject: [PATCH 01/10] changes in response --- .../com/kedia/ogparser/JsoupNetworkCall.kt | 15 ++++++++++++-- .../com/kedia/ogparser/UtilityFunctions.kt | 8 ++++++++ .../kedia/opengraphpreview/MainActivity.kt | 20 ++++++++++--------- 3 files changed, 32 insertions(+), 11 deletions(-) diff --git a/OGParser/src/main/java/com/kedia/ogparser/JsoupNetworkCall.kt b/OGParser/src/main/java/com/kedia/ogparser/JsoupNetworkCall.kt index 3a715ca..5b55d0c 100644 --- a/OGParser/src/main/java/com/kedia/ogparser/JsoupNetworkCall.kt +++ b/OGParser/src/main/java/com/kedia/ogparser/JsoupNetworkCall.kt @@ -1,8 +1,6 @@ package com.kedia.ogparser import android.util.Log -import kotlinx.coroutines.Dispatchers -import kotlinx.coroutines.launch import org.jsoup.Jsoup class JsoupNetworkCall { @@ -62,6 +60,19 @@ class JsoupNetworkCall { } } } + + Log.e("TAG!!!!!", "result ${doc.select("meta[name=description]").first().attr("content")} ${checkNullParserResult(openGraphResult)}") + + if (openGraphResult!!.title.isNullOrEmpty()) + openGraphResult!!.title = doc.title() + if (openGraphResult!!.description.isNullOrEmpty()) + openGraphResult!!.description = if (doc.select("meta[name=description]").size != 0) doc.select("meta[name=description]") + .first().attr("content") else "" + if (openGraphResult!!.url.isNullOrEmpty()) + openGraphResult!!.url = getBaseUrl(url) + + + } catch (e: Exception) { e.printStackTrace() return null diff --git a/OGParser/src/main/java/com/kedia/ogparser/UtilityFunctions.kt b/OGParser/src/main/java/com/kedia/ogparser/UtilityFunctions.kt index 8d665ff..d7e35b3 100644 --- a/OGParser/src/main/java/com/kedia/ogparser/UtilityFunctions.kt +++ b/OGParser/src/main/java/com/kedia/ogparser/UtilityFunctions.kt @@ -1,5 +1,8 @@ package com.kedia.ogparser +import java.net.URI +import java.net.URL + fun checkNullParserResult(openGraphResult: OpenGraphResult?): Boolean { return (openGraphResult?.title.isNullOrEmpty() || openGraphResult?.title.equals("null")) && @@ -7,4 +10,9 @@ fun checkNullParserResult(openGraphResult: OpenGraphResult?): Boolean { openGraphResult?.description.equals( "null" )) +} + +fun getBaseUrl(urlString: String): String { + val url: URL = URI.create(urlString).toURL() + return url.protocol.toString() + "://" + url.authority + "/" } \ No newline at end of file diff --git a/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt b/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt index d93a95c..a844e0e 100644 --- a/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt +++ b/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt @@ -13,15 +13,17 @@ class MainActivity : AppCompatActivity(), OpenGraphCallback { private val openGraphParser by lazy { OpenGraphParser(this, showNullOnEmpty = true) } private val LINKS_TO_TEST = mutableListOf( - "https://www.linkedin.com/posts/madhusmita-padhy_machinelearning-datascience-activity-6886390508722163712-yhQ0", - "https://www.youtube.com/watch?v=n3zsoX7bRlc", - "https://twitter.com/levelsio/status/1481942293108359168", - "https://stackoverflow.com/questions/44515769/conda-is-not-recognized-as-internal-or-external-command", - "https://github.com/Priyansh-Kedia/OpenGraphParser", - "https://chat.whatsapp.com/DdWAKRkt2VfAmd4OS47y7P", - "https://www.reddit.com/r/MachineLearning/comments/s3mjqf/deep_learning_interviews_hundreds_of_fully_solved/?utm_medium=android_app&utm_source=share", - "https://instagram.com/fcbarcelona?utm_medium=copy_link", - "https://www.facebook.com/groups/777946865955982/permalink/1385110621906267/" +// "https://www.linkedin.com/posts/madhusmita-padhy_machinelearning-datascience-activity-6886390508722163712-yhQ0", +// "https://www.youtube.com/watch?v=n3zsoX7bRlc", +// "https://twitter.com/levelsio/status/1481942293108359168", +// "https://stackoverflow.com/questions/44515769/conda-is-not-recognized-as-internal-or-external-command", +// "https://github.com/Priyansh-Kedia/OpenGraphParser", +// "https://chat.whatsapp.com/DdWAKRkt2VfAmd4OS47y7P", +// "https://www.reddit.com/r/MachineLearning/comments/s3mjqf/deep_learning_interviews_hundreds_of_fully_solved/?utm_medium=android_app&utm_source=share", +// "https://instagram.com/fcbarcelona?utm_medium=copy_link", +// "https://www.facebook.com/groups/777946865955982/permalink/1385110621906267/", + "https://www.youtube.com/", + "https://www.instagram.com/" ) override fun onCreate(savedInstanceState: Bundle?) { From f7960aa66777bdf8aacb771d0a900be1cdee74f6 Mon Sep 17 00:00:00 2001 From: Priyansh Kedia Date: Fri, 28 Jan 2022 13:25:38 +0530 Subject: [PATCH 02/10] minor fixes --- .../src/main/java/com/kedia/ogparser/JsoupNetworkCall.kt | 2 -- OGParser/src/main/java/com/kedia/ogparser/SharedPrefs.kt | 9 +++++++-- .../main/java/com/kedia/opengraphpreview/MainActivity.kt | 7 ++++--- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/OGParser/src/main/java/com/kedia/ogparser/JsoupNetworkCall.kt b/OGParser/src/main/java/com/kedia/ogparser/JsoupNetworkCall.kt index 5b55d0c..37ddd70 100644 --- a/OGParser/src/main/java/com/kedia/ogparser/JsoupNetworkCall.kt +++ b/OGParser/src/main/java/com/kedia/ogparser/JsoupNetworkCall.kt @@ -61,8 +61,6 @@ class JsoupNetworkCall { } } - Log.e("TAG!!!!!", "result ${doc.select("meta[name=description]").first().attr("content")} ${checkNullParserResult(openGraphResult)}") - if (openGraphResult!!.title.isNullOrEmpty()) openGraphResult!!.title = doc.title() if (openGraphResult!!.description.isNullOrEmpty()) diff --git a/OGParser/src/main/java/com/kedia/ogparser/SharedPrefs.kt b/OGParser/src/main/java/com/kedia/ogparser/SharedPrefs.kt index 1a0a600..45cbcb0 100644 --- a/OGParser/src/main/java/com/kedia/ogparser/SharedPrefs.kt +++ b/OGParser/src/main/java/com/kedia/ogparser/SharedPrefs.kt @@ -2,6 +2,7 @@ package com.kedia.ogparser import android.content.Context import android.content.SharedPreferences +import android.util.Log import androidx.preference.PreferenceManager class SharedPrefs(context: Context) { @@ -87,8 +88,12 @@ class SharedPrefs(context: Context) { val title = getTitle(url) val description = getDescription(url) val image = getImage(url) - - return title.isNotEmpty() && description.isNotEmpty() && image.isNotEmpty() + return title.isNotEmpty() && + title.equals("null").not() && + description.isNotEmpty() && + description.equals("null").not() //&& + image.isNotEmpty() && + image.equals("null").not() } } \ No newline at end of file diff --git a/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt b/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt index a844e0e..1847c4f 100644 --- a/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt +++ b/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt @@ -10,7 +10,7 @@ import kotlinx.android.synthetic.main.activity_main.* class MainActivity : AppCompatActivity(), OpenGraphCallback { - private val openGraphParser by lazy { OpenGraphParser(this, showNullOnEmpty = true) } + private val openGraphParser by lazy { OpenGraphParser(this, showNullOnEmpty = true, context = this) } private val LINKS_TO_TEST = mutableListOf( // "https://www.linkedin.com/posts/madhusmita-padhy_machinelearning-datascience-activity-6886390508722163712-yhQ0", @@ -22,8 +22,9 @@ class MainActivity : AppCompatActivity(), OpenGraphCallback { // "https://www.reddit.com/r/MachineLearning/comments/s3mjqf/deep_learning_interviews_hundreds_of_fully_solved/?utm_medium=android_app&utm_source=share", // "https://instagram.com/fcbarcelona?utm_medium=copy_link", // "https://www.facebook.com/groups/777946865955982/permalink/1385110621906267/", - "https://www.youtube.com/", - "https://www.instagram.com/" +// "https://www.youtube.com/", +// "https://www.instagram.com/", + "https://klusterapp.io/kluster/message?message_id=7244&channel_id=2247&Channel_name=new-channel-with-spa&kluster_id=64" ) override fun onCreate(savedInstanceState: Bundle?) { From 1540bb6cc4464c7899fb6a3fc4e4f28e03e96b6a Mon Sep 17 00:00:00 2001 From: Priyansh Kedia Date: Fri, 28 Jan 2022 13:43:16 +0530 Subject: [PATCH 03/10] minor fixes --- OGParser/src/main/java/com/kedia/ogparser/SharedPrefs.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OGParser/src/main/java/com/kedia/ogparser/SharedPrefs.kt b/OGParser/src/main/java/com/kedia/ogparser/SharedPrefs.kt index 45cbcb0..22acb54 100644 --- a/OGParser/src/main/java/com/kedia/ogparser/SharedPrefs.kt +++ b/OGParser/src/main/java/com/kedia/ogparser/SharedPrefs.kt @@ -91,7 +91,7 @@ class SharedPrefs(context: Context) { return title.isNotEmpty() && title.equals("null").not() && description.isNotEmpty() && - description.equals("null").not() //&& + description.equals("null").not() && image.isNotEmpty() && image.equals("null").not() } From 8abefc57e6303d1f5487142e6cc7e49731338262 Mon Sep 17 00:00:00 2001 From: Priyansh Kedia Date: Fri, 28 Jan 2022 13:56:29 +0530 Subject: [PATCH 04/10] removed images --- images/Story-Medium.svg | 1 - images/google-devlib.svg | 1 - 2 files changed, 2 deletions(-) delete mode 100644 images/Story-Medium.svg delete mode 100644 images/google-devlib.svg diff --git a/images/Story-Medium.svg b/images/Story-Medium.svg deleted file mode 100644 index ed47109..0000000 --- a/images/Story-Medium.svg +++ /dev/null @@ -1 +0,0 @@ - StoryStoryMediumMedium \ No newline at end of file diff --git a/images/google-devlib.svg b/images/google-devlib.svg deleted file mode 100644 index 2964026..0000000 --- a/images/google-devlib.svg +++ /dev/null @@ -1 +0,0 @@ -Google: Developer LibraryGoogleDeveloper Library \ No newline at end of file From 9bd672355edf2c9282073852f052f248e532bb72 Mon Sep 17 00:00:00 2001 From: Priyansh Kedia Date: Fri, 28 Jan 2022 14:16:47 +0530 Subject: [PATCH 05/10] added some changes --- OGParser/build.gradle | 1 + .../com/kedia/ogparser/JsoupNetworkCall.kt | 3 - .../kedia/opengraphpreview/MainActivity.kt | 22 +-- gradlew | 172 +++++++++--------- 4 files changed, 97 insertions(+), 101 deletions(-) diff --git a/OGParser/build.gradle b/OGParser/build.gradle index 6edfeae..0ef273e 100644 --- a/OGParser/build.gradle +++ b/OGParser/build.gradle @@ -1,6 +1,7 @@ plugins { id 'com.android.library' id 'kotlin-android' + id 'maven-publish' } android { diff --git a/OGParser/src/main/java/com/kedia/ogparser/JsoupNetworkCall.kt b/OGParser/src/main/java/com/kedia/ogparser/JsoupNetworkCall.kt index 37ddd70..1acb4f0 100644 --- a/OGParser/src/main/java/com/kedia/ogparser/JsoupNetworkCall.kt +++ b/OGParser/src/main/java/com/kedia/ogparser/JsoupNetworkCall.kt @@ -68,9 +68,6 @@ class JsoupNetworkCall { .first().attr("content") else "" if (openGraphResult!!.url.isNullOrEmpty()) openGraphResult!!.url = getBaseUrl(url) - - - } catch (e: Exception) { e.printStackTrace() return null diff --git a/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt b/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt index 1847c4f..7a8f1f5 100644 --- a/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt +++ b/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt @@ -13,17 +13,17 @@ class MainActivity : AppCompatActivity(), OpenGraphCallback { private val openGraphParser by lazy { OpenGraphParser(this, showNullOnEmpty = true, context = this) } private val LINKS_TO_TEST = mutableListOf( -// "https://www.linkedin.com/posts/madhusmita-padhy_machinelearning-datascience-activity-6886390508722163712-yhQ0", -// "https://www.youtube.com/watch?v=n3zsoX7bRlc", -// "https://twitter.com/levelsio/status/1481942293108359168", -// "https://stackoverflow.com/questions/44515769/conda-is-not-recognized-as-internal-or-external-command", -// "https://github.com/Priyansh-Kedia/OpenGraphParser", -// "https://chat.whatsapp.com/DdWAKRkt2VfAmd4OS47y7P", -// "https://www.reddit.com/r/MachineLearning/comments/s3mjqf/deep_learning_interviews_hundreds_of_fully_solved/?utm_medium=android_app&utm_source=share", -// "https://instagram.com/fcbarcelona?utm_medium=copy_link", -// "https://www.facebook.com/groups/777946865955982/permalink/1385110621906267/", -// "https://www.youtube.com/", -// "https://www.instagram.com/", + "https://www.linkedin.com/posts/madhusmita-padhy_machinelearning-datascience-activity-6886390508722163712-yhQ0", + "https://www.youtube.com/watch?v=n3zsoX7bRlc", + "https://twitter.com/levelsio/status/1481942293108359168", + "https://stackoverflow.com/questions/44515769/conda-is-not-recognized-as-internal-or-external-command", + "https://github.com/Priyansh-Kedia/OpenGraphParser", + "https://chat.whatsapp.com/DdWAKRkt2VfAmd4OS47y7P", + "https://www.reddit.com/r/MachineLearning/comments/s3mjqf/deep_learning_interviews_hundreds_of_fully_solved/?utm_medium=android_app&utm_source=share", + "https://instagram.com/fcbarcelona?utm_medium=copy_link", + "https://www.facebook.com/groups/777946865955982/permalink/1385110621906267/", + "https://www.youtube.com/", + "https://www.instagram.com/", "https://klusterapp.io/kluster/message?message_id=7244&channel_id=2247&Channel_name=new-channel-with-spa&kluster_id=64" ) diff --git a/gradlew b/gradlew index cccdd3d..a50e23b 100755 --- a/gradlew +++ b/gradlew @@ -11,13 +11,13 @@ PRG="$0" # Need this for relative symlinks. while [ -h "$PRG" ] ; do - ls=`ls -ld "$PRG"` - link=`expr "$ls" : '.*-> \(.*\)$'` - if expr "$link" : '/.*' > /dev/null; then - PRG="$link" - else - PRG=`dirname "$PRG"`"/$link" - fi +ls=`ls -ld "$PRG"` +link=`expr "$ls" : '.*-> \(.*\)$'` +if expr "$link" : '/.*' > /dev/null; then +PRG="$link" +else +PRG=`dirname "$PRG"`"/$link" +fi done SAVED="`pwd`" cd "`dirname \"$PRG\"`/" >/dev/null @@ -50,108 +50,106 @@ msys=false darwin=false nonstop=false case "`uname`" in - CYGWIN* ) - cygwin=true - ;; - Darwin* ) - darwin=true - ;; - MINGW* ) - msys=true - ;; - NONSTOP* ) - nonstop=true - ;; +CYGWIN* ) +cygwin=true +;; +Darwin* ) +darwin=true +;; +MINGW* ) +msys=true +;; +NONSTOP* ) +nonstop=true +;; esac CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar # Determine the Java command to use to start the JVM. if [ -n "$JAVA_HOME" ] ; then - if [ -x "$JAVA_HOME/jre/sh/java" ] ; then - # IBM's JDK on AIX uses strange locations for the executables - JAVACMD="$JAVA_HOME/jre/sh/java" - else - JAVACMD="$JAVA_HOME/bin/java" - fi - if [ ! -x "$JAVACMD" ] ; then - die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME - +if [ -x "$JAVA_HOME/jre/sh/java" ] ; then +# IBM's JDK on AIX uses strange locations for the executables +JAVACMD="$JAVA_HOME/jre/sh/java" +else +JAVACMD="$JAVA_HOME/bin/java" +fi +if [ ! -x "$JAVACMD" ] ; then +die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME Please set the JAVA_HOME variable in your environment to match the location of your Java installation." - fi +fi else - JAVACMD="java" - which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. - +JAVACMD="java" +which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. Please set the JAVA_HOME variable in your environment to match the location of your Java installation." fi # Increase the maximum file descriptors if we can. if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then - MAX_FD_LIMIT=`ulimit -H -n` - if [ $? -eq 0 ] ; then - if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then - MAX_FD="$MAX_FD_LIMIT" - fi - ulimit -n $MAX_FD - if [ $? -ne 0 ] ; then - warn "Could not set maximum file descriptor limit: $MAX_FD" - fi - else - warn "Could not query maximum file descriptor limit: $MAX_FD_LIMIT" - fi +MAX_FD_LIMIT=`ulimit -H -n` +if [ $? -eq 0 ] ; then +if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then +MAX_FD="$MAX_FD_LIMIT" +fi +ulimit -n $MAX_FD +if [ $? -ne 0 ] ; then +warn "Could not set maximum file descriptor limit: $MAX_FD" +fi +else +warn "Could not query maximum file descriptor limit: $MAX_FD_LIMIT" +fi fi # For Darwin, add options to specify how the application appears in the dock if $darwin; then - GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\"" +GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\"" fi # For Cygwin, switch paths to Windows format before running java if $cygwin ; then - APP_HOME=`cygpath --path --mixed "$APP_HOME"` - CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` - JAVACMD=`cygpath --unix "$JAVACMD"` - - # We build the pattern for arguments to be converted via cygpath - ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null` - SEP="" - for dir in $ROOTDIRSRAW ; do - ROOTDIRS="$ROOTDIRS$SEP$dir" - SEP="|" - done - OURCYGPATTERN="(^($ROOTDIRS))" - # Add a user-defined pattern to the cygpath arguments - if [ "$GRADLE_CYGPATTERN" != "" ] ; then - OURCYGPATTERN="$OURCYGPATTERN|($GRADLE_CYGPATTERN)" - fi - # Now convert the arguments - kludge to limit ourselves to /bin/sh - i=0 - for arg in "$@" ; do - CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -` - CHECK2=`echo "$arg"|egrep -c "^-"` ### Determine if an option - - if [ $CHECK -ne 0 ] && [ $CHECK2 -eq 0 ] ; then ### Added a condition - eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"` - else - eval `echo args$i`="\"$arg\"" - fi - i=$((i+1)) - done - case $i in - (0) set -- ;; - (1) set -- "$args0" ;; - (2) set -- "$args0" "$args1" ;; - (3) set -- "$args0" "$args1" "$args2" ;; - (4) set -- "$args0" "$args1" "$args2" "$args3" ;; - (5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;; - (6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;; - (7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;; - (8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;; - (9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;; - esac +APP_HOME=`cygpath --path --mixed "$APP_HOME"` +CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` +JAVACMD=`cygpath --unix "$JAVACMD"` + +# We build the pattern for arguments to be converted via cygpath +ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null` +SEP="" +for dir in $ROOTDIRSRAW ; do +ROOTDIRS="$ROOTDIRS$SEP$dir" +SEP="|" +done +OURCYGPATTERN="(^($ROOTDIRS))" +# Add a user-defined pattern to the cygpath arguments +if [ "$GRADLE_CYGPATTERN" != "" ] ; then +OURCYGPATTERN="$OURCYGPATTERN|($GRADLE_CYGPATTERN)" +fi +# Now convert the arguments - kludge to limit ourselves to /bin/sh +i=0 +for arg in "$@" ; do +CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -` +CHECK2=`echo "$arg"|egrep -c "^-"` ### Determine if an option + +if [ $CHECK -ne 0 ] && [ $CHECK2 -eq 0 ] ; then ### Added a condition +eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"` +else +eval `echo args$i`="\"$arg\"" +fi +i=$((i+1)) +done +case $i in +(0) set -- ;; +(1) set -- "$args0" ;; +(2) set -- "$args0" "$args1" ;; +(3) set -- "$args0" "$args1" "$args2" ;; +(4) set -- "$args0" "$args1" "$args2" "$args3" ;; +(5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;; +(6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;; +(7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;; +(8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;; +(9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;; +esac fi # Escape application args @@ -166,7 +164,7 @@ eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$A # by default we should be in the correct project dir, but when run from Finder on Mac, the cwd is wrong if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then - cd "$(dirname "$0")" +cd "$(dirname "$0")" fi exec "$JAVACMD" "$@" From 385c156e14fb3ec6c4716dd3de2a8ee592ea9135 Mon Sep 17 00:00:00 2001 From: Priyansh Kedia Date: Fri, 28 Jan 2022 14:25:07 +0530 Subject: [PATCH 06/10] added some changes --- OGParser/build.gradle | 2 ++ 1 file changed, 2 insertions(+) diff --git a/OGParser/build.gradle b/OGParser/build.gradle index 0ef273e..db06eaf 100644 --- a/OGParser/build.gradle +++ b/OGParser/build.gradle @@ -4,6 +4,8 @@ plugins { id 'maven-publish' } +group = 'com.github.Priyansh-Kedia' + android { compileSdkVersion 30 buildToolsVersion "30.0.3" From 3f0d7dfb113d19733357a932fc0a9faff4a0e2b7 Mon Sep 17 00:00:00 2001 From: Priyansh Kedia Date: Fri, 28 Jan 2022 14:40:39 +0530 Subject: [PATCH 07/10] changes --- OGParser/build.gradle | 3 +- gradlew | 170 +++++++++++++++++++++--------------------- settings.gradle | 2 - 3 files changed, 87 insertions(+), 88 deletions(-) diff --git a/OGParser/build.gradle b/OGParser/build.gradle index db06eaf..6cf710c 100644 --- a/OGParser/build.gradle +++ b/OGParser/build.gradle @@ -4,7 +4,6 @@ plugins { id 'maven-publish' } -group = 'com.github.Priyansh-Kedia' android { compileSdkVersion 30 @@ -62,3 +61,5 @@ dependencies { // implementation "androidx.lifecycle:lifecycle-extensions:${lifecycle_version}" // implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:${lifecycle_version}" } + +group = 'com.github.Priyansh-Kedia' diff --git a/gradlew b/gradlew index a50e23b..f48d5d0 100755 --- a/gradlew +++ b/gradlew @@ -11,13 +11,13 @@ PRG="$0" # Need this for relative symlinks. while [ -h "$PRG" ] ; do -ls=`ls -ld "$PRG"` -link=`expr "$ls" : '.*-> \(.*\)$'` -if expr "$link" : '/.*' > /dev/null; then -PRG="$link" -else -PRG=`dirname "$PRG"`"/$link" -fi + ls=`ls -ld "$PRG"` + link=`expr "$ls" : '.*-> \(.*\)$'` + if expr "$link" : '/.*' > /dev/null; then + PRG="$link" + else + PRG=`dirname "$PRG"`"/$link" + fi done SAVED="`pwd`" cd "`dirname \"$PRG\"`/" >/dev/null @@ -50,106 +50,106 @@ msys=false darwin=false nonstop=false case "`uname`" in -CYGWIN* ) -cygwin=true -;; -Darwin* ) -darwin=true -;; -MINGW* ) -msys=true -;; -NONSTOP* ) -nonstop=true -;; + CYGWIN* ) + cygwin=true + ;; + Darwin* ) + darwin=true + ;; + MINGW* ) + msys=true + ;; + NONSTOP* ) + nonstop=true + ;; esac CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar # Determine the Java command to use to start the JVM. if [ -n "$JAVA_HOME" ] ; then -if [ -x "$JAVA_HOME/jre/sh/java" ] ; then -# IBM's JDK on AIX uses strange locations for the executables -JAVACMD="$JAVA_HOME/jre/sh/java" -else -JAVACMD="$JAVA_HOME/bin/java" -fi -if [ ! -x "$JAVACMD" ] ; then -die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME + if [ -x "$JAVA_HOME/jre/sh/java" ] ; then + # IBM's JDK on AIX uses strange locations for the executables + JAVACMD="$JAVA_HOME/jre/sh/java" + else + JAVACMD="$JAVA_HOME/bin/java" + fi + if [ ! -x "$JAVACMD" ] ; then + die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME Please set the JAVA_HOME variable in your environment to match the location of your Java installation." -fi + fi else -JAVACMD="java" -which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. + JAVACMD="java" + which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. Please set the JAVA_HOME variable in your environment to match the location of your Java installation." fi # Increase the maximum file descriptors if we can. if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then -MAX_FD_LIMIT=`ulimit -H -n` -if [ $? -eq 0 ] ; then -if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then -MAX_FD="$MAX_FD_LIMIT" -fi -ulimit -n $MAX_FD -if [ $? -ne 0 ] ; then -warn "Could not set maximum file descriptor limit: $MAX_FD" -fi -else -warn "Could not query maximum file descriptor limit: $MAX_FD_LIMIT" -fi + MAX_FD_LIMIT=`ulimit -H -n` + if [ $? -eq 0 ] ; then + if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then + MAX_FD="$MAX_FD_LIMIT" + fi + ulimit -n $MAX_FD + if [ $? -ne 0 ] ; then + warn "Could not set maximum file descriptor limit: $MAX_FD" + fi + else + warn "Could not query maximum file descriptor limit: $MAX_FD_LIMIT" + fi fi # For Darwin, add options to specify how the application appears in the dock if $darwin; then -GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\"" + GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\"" fi # For Cygwin, switch paths to Windows format before running java if $cygwin ; then -APP_HOME=`cygpath --path --mixed "$APP_HOME"` -CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` -JAVACMD=`cygpath --unix "$JAVACMD"` - -# We build the pattern for arguments to be converted via cygpath -ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null` -SEP="" -for dir in $ROOTDIRSRAW ; do -ROOTDIRS="$ROOTDIRS$SEP$dir" -SEP="|" -done -OURCYGPATTERN="(^($ROOTDIRS))" -# Add a user-defined pattern to the cygpath arguments -if [ "$GRADLE_CYGPATTERN" != "" ] ; then -OURCYGPATTERN="$OURCYGPATTERN|($GRADLE_CYGPATTERN)" -fi -# Now convert the arguments - kludge to limit ourselves to /bin/sh -i=0 -for arg in "$@" ; do -CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -` -CHECK2=`echo "$arg"|egrep -c "^-"` ### Determine if an option - -if [ $CHECK -ne 0 ] && [ $CHECK2 -eq 0 ] ; then ### Added a condition -eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"` -else -eval `echo args$i`="\"$arg\"" -fi -i=$((i+1)) -done -case $i in -(0) set -- ;; -(1) set -- "$args0" ;; -(2) set -- "$args0" "$args1" ;; -(3) set -- "$args0" "$args1" "$args2" ;; -(4) set -- "$args0" "$args1" "$args2" "$args3" ;; -(5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;; -(6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;; -(7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;; -(8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;; -(9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;; -esac + APP_HOME=`cygpath --path --mixed "$APP_HOME"` + CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` + JAVACMD=`cygpath --unix "$JAVACMD"` + + # We build the pattern for arguments to be converted via cygpath + ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null` + SEP="" + for dir in $ROOTDIRSRAW ; do + ROOTDIRS="$ROOTDIRS$SEP$dir" + SEP="|" + done + OURCYGPATTERN="(^($ROOTDIRS))" + # Add a user-defined pattern to the cygpath arguments + if [ "$GRADLE_CYGPATTERN" != "" ] ; then + OURCYGPATTERN="$OURCYGPATTERN|($GRADLE_CYGPATTERN)" + fi + # Now convert the arguments - kludge to limit ourselves to /bin/sh + i=0 + for arg in "$@" ; do + CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -` + CHECK2=`echo "$arg"|egrep -c "^-"` ### Determine if an option + + if [ $CHECK -ne 0 ] && [ $CHECK2 -eq 0 ] ; then ### Added a condition + eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"` + else + eval `echo args$i`="\"$arg\"" + fi + i=$((i+1)) + done + case $i in + (0) set -- ;; + (1) set -- "$args0" ;; + (2) set -- "$args0" "$args1" ;; + (3) set -- "$args0" "$args1" "$args2" ;; + (4) set -- "$args0" "$args1" "$args2" "$args3" ;; + (5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;; + (6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;; + (7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;; + (8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;; + (9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;; + esac fi # Escape application args @@ -164,7 +164,7 @@ eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$A # by default we should be in the correct project dir, but when run from Finder on Mac, the cwd is wrong if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then -cd "$(dirname "$0")" + cd "$(dirname "$0")" fi exec "$JAVACMD" "$@" diff --git a/settings.gradle b/settings.gradle index 30ec570..28aa392 100644 --- a/settings.gradle +++ b/settings.gradle @@ -1,3 +1 @@ -rootProject.name = "OpenGraphPreview" -include ':app' include ':OGParser' From 09dde74338cf699458787447d962190e9eba0474 Mon Sep 17 00:00:00 2001 From: Priyansh Kedia Date: Fri, 28 Jan 2022 17:29:23 +0530 Subject: [PATCH 08/10] changes in gradle --- app/build.gradle | 1 + app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt | 2 +- gradlew | 2 ++ settings.gradle | 2 ++ 4 files changed, 6 insertions(+), 1 deletion(-) diff --git a/app/build.gradle b/app/build.gradle index 1725b44..b4e47c7 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -44,5 +44,6 @@ dependencies { testImplementation 'junit:junit:4.+' androidTestImplementation 'androidx.test.ext:junit:1.1.3' androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0' +// implementation 'com.github.Priyansh-Kedia:OpenGraphParser:3f0d7dfb11' } \ No newline at end of file diff --git a/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt b/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt index 7a8f1f5..01232e6 100644 --- a/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt +++ b/app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt @@ -10,7 +10,7 @@ import kotlinx.android.synthetic.main.activity_main.* class MainActivity : AppCompatActivity(), OpenGraphCallback { - private val openGraphParser by lazy { OpenGraphParser(this, showNullOnEmpty = true, context = this) } + private val openGraphParser by lazy { OpenGraphParser(this, showNullOnEmpty = true) } private val LINKS_TO_TEST = mutableListOf( "https://www.linkedin.com/posts/madhusmita-padhy_machinelearning-datascience-activity-6886390508722163712-yhQ0", diff --git a/gradlew b/gradlew index f48d5d0..cccdd3d 100755 --- a/gradlew +++ b/gradlew @@ -76,12 +76,14 @@ if [ -n "$JAVA_HOME" ] ; then fi if [ ! -x "$JAVACMD" ] ; then die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME + Please set the JAVA_HOME variable in your environment to match the location of your Java installation." fi else JAVACMD="java" which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. + Please set the JAVA_HOME variable in your environment to match the location of your Java installation." fi diff --git a/settings.gradle b/settings.gradle index 28aa392..30ec570 100644 --- a/settings.gradle +++ b/settings.gradle @@ -1 +1,3 @@ +rootProject.name = "OpenGraphPreview" +include ':app' include ':OGParser' From c358175a2e2e2adc816d0e1227103dfc22d4f2bb Mon Sep 17 00:00:00 2001 From: Priyansh Kedia Date: Fri, 28 Jan 2022 17:58:32 +0530 Subject: [PATCH 09/10] change in build gradle --- OGParser/build.gradle | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/OGParser/build.gradle b/OGParser/build.gradle index 6cf710c..48699c4 100644 --- a/OGParser/build.gradle +++ b/OGParser/build.gradle @@ -62,4 +62,28 @@ dependencies { // implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:${lifecycle_version}" } -group = 'com.github.Priyansh-Kedia' +afterEvaluate { + publishing { + publications { + // Creates a Maven publication called "release". + release(MavenPublication) { + // Applies the component for the release build variant. + from components.release + + // You can then customize attributes of the publication as shown below. + groupId = 'com.github.Priyansh-Kedia' + artifactId = 'final' + version = '2.5.3' + } + // Creates a Maven publication called “debug”. + debug(MavenPublication) { + // Applies the component for the debug build variant. + from components.debug + + groupId = 'com.github.Priyansh-Kedia' + artifactId = 'final-debug' + version = '2.5.3' + } + } + } +} \ No newline at end of file From 8d60b3cfcc50907e900135b086f09b35e00bbc53 Mon Sep 17 00:00:00 2001 From: Priyansh Kedia Date: Fri, 28 Jan 2022 18:12:42 +0530 Subject: [PATCH 10/10] added images --- images/Story-Medium.svg | 1 + images/google-devlib.svg | 1 + 2 files changed, 2 insertions(+) create mode 100644 images/Story-Medium.svg create mode 100644 images/google-devlib.svg diff --git a/images/Story-Medium.svg b/images/Story-Medium.svg new file mode 100644 index 0000000..ed47109 --- /dev/null +++ b/images/Story-Medium.svg @@ -0,0 +1 @@ + StoryStoryMediumMedium \ No newline at end of file diff --git a/images/google-devlib.svg b/images/google-devlib.svg new file mode 100644 index 0000000..2964026 --- /dev/null +++ b/images/google-devlib.svg @@ -0,0 +1 @@ +Google: Developer LibraryGoogleDeveloper Library \ No newline at end of file