Merge pull request #34 from pj8/span

不要コードを削除
pj8 · Dec 20, 2021 · acaf43a · acaf43a
2 parents 36bf16f + db97a4d
commit acaf43a
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 27 deletions.
diff --git a/src/ResourceTrace.php b/src/ResourceTrace.php
@@ -43,7 +43,6 @@ public function setCurrentSpan(ResourceObject $result): void
 
         /** @psalm-suppress StaticAccess */
         $tracingSpan->setStatus(SpanStatus::createFromHttpStatusCode($result->code));
-        $this->span->setCurrentSpan($tracingSpan);
     }
 
     public function setTransaction(ResourceObject $result): void
@@ -55,7 +54,6 @@ public function setTransaction(ResourceObject $result): void
         $tracingTran = $this->transaction->getTransaction();
         /** @psalm-suppress StaticAccess */
         $tracingTran->setStatus(SpanStatus::createFromHttpStatusCode($result->code));
-        $this->transaction->setTransaction($tracingTran);
     }
 
     public function isFirstSpan(): bool

diff --git a/src/Span.php b/src/Span.php
@@ -64,20 +64,6 @@ public function getCurrentSpan()
         return null;
     }
 
-    public function setCurrentSpan(?TracingSpan $span): void
-    {
-        if (count($this->spans) === 0) {
-            return;
-        }
-
-        $span = array_pop($this->spans);
-        if (! $span) {
-            return;
-        }
-
-        $this->spans[] = $span;
-    }
-
     public function isFirst(): bool
     {
         // First Span (Transaction's child)

diff --git a/src/SpanInterface.php b/src/SpanInterface.php
@@ -18,7 +18,5 @@ public function finish(): void;
      */
     public function getCurrentSpan();
 
-    public function setCurrentSpan(?TracingSpan $span): void;
-
     public function isFirst(): bool;
 }
diff --git a/src/Transaction.php b/src/Transaction.php
@@ -63,9 +63,4 @@ public function getTransaction(): SentryTransaction
     {
         return $this->transaction;
     }
-
-    public function setTransaction(SentryTransaction $transaction): void
-    {
-        $this->transaction = $transaction;
-    }
 }
diff --git a/src/TransactionInterface.php b/src/TransactionInterface.php
@@ -9,6 +9,4 @@
 interface TransactionInterface extends StartChildInterface
 {
     public function getTransaction(): SentryTransaction;
-
-    public function setTransaction(SentryTransaction $transaction): void;
 }
diff --git a/tests/ResourceTraceTest.php b/tests/ResourceTraceTest.php
@@ -33,7 +33,6 @@ public function testSetCurrentSpanUpdateSpan(): void
 
         $mockSpan = $this->createMock(SpanInterface::class);
         $mockSpan->expects($this->once())->method('getCurrentSpan')->willReturn($sentrySpan);
-        $mockSpan->expects($this->once())->method('setCurrentSpan');
 
         $factory = new SpanContextFactory(new ResourceSpanFactory());
 
@@ -49,7 +48,6 @@ public function testSetTransactionUpdateTransaction(): void
 
         $mockTransaction = $this->createMock(TransactionInterface::class);
         $mockTransaction->expects($this->once())->method('getTransaction')->willReturn($sentryTransaction);
-        $mockTransaction->expects($this->once())->method('setTransaction');
 
         $span = new Span(new Transaction(['dsn' => null], 'test-dummy'));