deps: Bump eslint suite to v9 #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrated the eslint config using `npx @eslint/migrate-config .eslintrc.json`, and did not work flawlessly, obviously I had to include config to examples into the root config file. Instead, we are able to delete `.eslintrc` that existed for each example directory though `require-atomic-updates` (has been set to `off`) does not exist in the default configs, so removed the line `@typescript-eslint/no-unnecessary-type-assertion` requires a type assertion, removed it for now
0b5vr
added
dependencies
yue4u
reviewed
Mar 4, 2025
Comment on lines
-208
to
+210
| parentBoneName ?? (parentBoneName = 'hipsParent'); | ||
| if (parentBoneName == null) { | ||
| parentBoneName = 'hipsParent'; | ||
| } |
There was a problem hiding this comment.
Do you mean
Suggested change
| parentBoneName ?? (parentBoneName = 'hipsParent'); | |
| if (parentBoneName == null) { | |
| parentBoneName = 'hipsParent'; | |
| } | |
| parentBoneName ??= 'hipsParent' |
yue4u
reviewed
Mar 4, 2025
seem to be errors of |
These `@typescript-eslint/naming-convention` errors can be easily fixed by inserting brackets Addresses: #1565 (review)
yue4u
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps eslint suite to v9.
This also migrates the existing eslint configs to the new flat config.
See the commit logs for details.