Add gke PodMonitoring compatible labels for prometheus scrape-able services #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vices Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
commented
Jul 12, 2024
| @@ -14,6 +14,9 @@ spec: | |||
| labels: | |||
| name: indexer-server | |||
| monitoring.gke.io/scrape: 'true' | |||
| prometheus.io/scrape: 'true' | |||
| prometheus.io/port: '51801' | |||
| prometheus.io/scheme: 'http' | |||
There was a problem hiding this comment.
I tried to use a yaml anchor to avoid duplicating these, but skaffold wasn't compatible with it:
|
The podMonitoring should only need labels to identify workloads to scrape. It then uses prometheus to scrape those targets which AFAIK still relies on the annotations. |
|
ah, I see. I can confirm that using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add gke PodMonitoring compatible labels for prometheus scrape-able services
GKE's managed prometheus works by creating PodMonitoring resources that identify what targets to scrape. This resource only supports matching by labels and does not work with the existing annotations present in the Pixie cloud manifests. This PR adds PodMonitoring compatible labels that match the existing annotations
Relevant Issues: N/A
Type of change: /kind compatibility
Test Plan: Skaffold'ed to a cluster and verified the following: