Skip to content

Adding version information to requirements.txt #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ryuno-Ki opened this issue Aug 2, 2019 · 7 comments
Closed

Adding version information to requirements.txt #1

Ryuno-Ki opened this issue Aug 2, 2019 · 7 comments

Comments

@Ryuno-Ki
Copy link

Ryuno-Ki commented Aug 2, 2019

Hi Julien,

since you are writing a library, you should add version hints on your requirements.txt. You can use pip freeze for that.

This way, you can utilise tools to check for breaking changes caused by your dependencies.
Plus, it makes debugging easier, since you can more or less be sure to run the same version than the person opening an issue.

@pitchmuc
Copy link
Owner

Thanks for the tip.
I'll do that soon then. I let that thread open so I can close it when I documented the minimum version of my dependencies.
Thank you very much for all the great tips.

I hope you have seen that I have updated the library since our presentation and there are cool features now, like "extractAnalyticsConfig"

@pitchmuc
Copy link
Owner

I am starting to write the wrapper for the Analytics API 2.0 now.
I hope to be finished by the end of the year (mostly time constraint than difficulties).
After that, I'll try to create a global adobe marketing cloud that you can download with pypi and that can be ran directly.
Stay tuned. ;)

@Ryuno-Ki
Copy link
Author

Ryuno-Ki commented Oct 2, 2019

Um, I fear I won't. I can explain it in more detail via mail if you are interested. (Orcheck my profile next month...)

@VikashKotharyWork
Copy link

I've created a PR #10 for adding a poetry pyproject.toml to the repo. I find it's a lot more powerful compared to the traditional requirements.txt as you have lock files and can separate dev and library requirements. What do you think @pitchmuc @Ryuno-Ki ?
See https://python-poetry.org/ for more information.

@Ryuno-Ki
Copy link
Author

More powerful also implies a steeper learning curve.
However, I never used Poetry or Make myself.

@VikashKotharyWork
Copy link

VikashKotharyWork commented Feb 25, 2020

TLDR; poetry add pylaunch, poetry add --dev pylaunch and poetry install.
No need for version information thanks to poetry.lock.
But I see your point. If you prefer the traditional method, I have seen repos which support both.

@pitchmuc
Copy link
Owner

pitchmuc commented May 9, 2020

I did add the version requirements for the publishing to pypi.

@pitchmuc pitchmuc closed this as completed May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants