Quantize in range [1, 2^b) #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elshize
force-pushed
the
fix-quantizer-zero-scores
branch
from
4c790af to
a821618
Compare
JMMackenzie
approved these changes
Feb 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #575 +/- ##
==========================================
- Coverage 93.29% 93.27% -0.02%
==========================================
Files 90 89 -1
Lines 4457 4448 -9
==========================================
- Hits 4158 4149 -9
Misses 299 299 ☔ View full report in Codecov by Sentry. |
elshize
force-pushed
the
fix-quantizer-zero-scores
branch
2 times, most recently
from
c56d323 to
b2a0439
Compare
Due to quantization, some scores can be 0, but our frequency encoding (which is used for scores) assumes positive values. To fix it, we quantize into a range starting at 1 instead. Changelog-changed: Scores are quantized starting at 1 instead of 0 Fixes: #572 Signed-off-by: Michal Siedlaczek <michal@siedlaczek.me>
elshize
force-pushed
the
fix-quantizer-zero-scores
branch
from
b2a0439 to
25ff231
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to quantization, some scores can be 0, but our frequency encoding (which is used for scores) assumes positive values. To fix it, we quantize into a range starting at 1 instead.
Fixes: #572