Concepts #571
Merged
Concepts #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #571 +/- ##
=======================================
Coverage 93.28% 93.29%
=======================================
Files 90 90
Lines 4454 4457 +3
=======================================
+ Hits 4155 4158 +3
Misses 299 299 ☔ View full report in Codecov by Sentry. |
elshize
force-pushed
the
concepts
branch
2 times, most recently
from
fa01b20 to
dd1ce20
Compare
elshize
force-pushed
the
concepts
branch
2 times, most recently
from
806bbb6 to
84ca85d
Compare
JMMackenzie
approved these changes
Feb 11, 2024
Introduce mapping concepts and use concept asserts for `TermMap` and its subclasses. Changelog-changed: `TermMap` uses `find` method instead of `operator()` for reverse lookup (string to int) Signed-off-by: Michal Siedlaczek <michal@siedlaczek.me>
Introduce posting list concepts & use them in the algorithms. Signed-off-by: Michal Siedlaczek <michal@siedlaczek.me>
Add inverted index concepts and static assertions for the existing index classes. Signed-off-by: Michal Siedlaczek <michal@siedlaczek.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set contains commits that introduce C++20 concepts for:
Concepts are only used when compiled in C++20 mode, ignored otherwise.
Assertions are added to known structures that satisfy these concepts.
Some
requireconstraints are also added, most notably for the algorithm execution that expect certain posting lists.Rationale
Concepts are introduced for faster constraint checking and explicit interface modeling when templates are used.