Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ranked_or_taat and ranked_or_taat_lazy #566

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Fix ranked_or_taat and ranked_or_taat_lazy #566

merged 2 commits into from
Jan 21, 2024

Conversation

amallia
Copy link
Member

@amallia amallia commented Jan 16, 2024

Currently ranked_or_taat and ranked_or_taat_lazy fail with segfault, this change should fix them.

Copy link
Member

@elshize elshize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, if you could just rebase on master and fix the formatting (the test looks to be failing) it would be perfect.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5caaf93) 93.23% compared to head (be513c1) 93.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          90       90           
  Lines        4452     4452           
=======================================
  Hits         4151     4151           
  Misses        301      301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amallia amallia merged commit d0efb61 into master Jan 21, 2024
@amallia amallia deleted the amallia-patch-2 branch January 21, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants