Add virtual constructor to block codecs

We construct codecs as a shared pointer to `BlockCodec` and without a
virtual destructor, only the destructor of the base class is called.
This has not caused any real issues because the codecs do not do any
memory management, but this is now for correctness and future-proofing.

Signed-off-by: Michal Siedlaczek <michal@siedlaczek.me>

.clang-tidy

@@ -25,3 +25,6 @@ Checks: |
     -fuchsia-trailing-return,
     -llvm-header-guard,
     -google-runtime-references
+CheckOptions:
+  - key: cppcoreguidelines-special-member-functions.AllowSoleDefaultDtor
+    value: true

include/pisa/codec/block_codec.hpp

@@ -13,6 +13,8 @@ namespace pisa {
  */
 class BlockCodec {
   public:
+    virtual ~BlockCodec() = default;
+
     /**
      * Encodes a list of `n` unsigned integers and appends them to the output buffer.
      */

include/pisa/codec/interpolative.hpp

@@ -19,6 +19,8 @@ class InterpolativeBlockCodec: public BlockCodec {
   public:
     constexpr static std::string_view name = "block_interpolative";
 
+    virtual ~InterpolativeBlockCodec() = default;
+
     void encode(uint32_t const* in, uint32_t sum_of_values, size_t n, std::vector<uint8_t>& out)
         const override;
     uint8_t const*

include/pisa/codec/maskedvbyte.hpp

@@ -19,6 +19,8 @@ class MaskedVByteBlockCodec: public BlockCodec {
   public:
     constexpr static std::string_view name = "block_maskedvbyte";
 
+    virtual ~MaskedVByteBlockCodec() = default;
+
     void encode(uint32_t const* in, uint32_t sum_of_values, size_t n, std::vector<uint8_t>& out)
         const override;
     uint8_t const*

include/pisa/codec/optpfor.hpp

@@ -26,6 +26,8 @@ class OptPForBlockCodec: public BlockCodec {
   public:
     constexpr static std::string_view name = "block_optpfor";
 
+    virtual ~OptPForBlockCodec() = default;
+
     void encode(uint32_t const* in, uint32_t sum_of_values, size_t n, std::vector<uint8_t>& out)
         const override;
     uint8_t const*

include/pisa/codec/qmx.hpp

@@ -19,6 +19,8 @@ class QmxBlockCodec: public BlockCodec {
   public:
     constexpr static std::string_view name = "block_qmx";
 
+    virtual ~QmxBlockCodec() = default;
+
     void encode(uint32_t const* in, uint32_t sum_of_values, size_t n, std::vector<uint8_t>& out)
         const override;
 

include/pisa/codec/simdbp.hpp

@@ -18,6 +18,8 @@ class SimdBpBlockCodec: public BlockCodec {
   public:
     constexpr static std::string_view name = "block_simdbp";
 
+    virtual ~SimdBpBlockCodec() = default;
+
     void encode(uint32_t const* in, uint32_t sum_of_values, size_t n, std::vector<uint8_t>& out)
         const override;
     uint8_t const*

include/pisa/codec/simple16.hpp

@@ -17,6 +17,8 @@ class Simple16BlockCodec: public BlockCodec {
   public:
     constexpr static std::string_view name = "block_simple16";
 
+    virtual ~Simple16BlockCodec() = default;
+
     void encode(uint32_t const* in, uint32_t sum_of_values, size_t n, std::vector<uint8_t>& out)
         const override;
     uint8_t const*

include/pisa/codec/simple8b.hpp

@@ -16,6 +16,8 @@ class Simple8bBlockCodec: public BlockCodec {
   public:
     constexpr static std::string_view name = "block_simple8b";
 
+    virtual ~Simple8bBlockCodec() = default;
+
     void encode(uint32_t const* in, uint32_t sum_of_values, size_t n, std::vector<uint8_t>& out)
         const override;
     uint8_t const*

include/pisa/codec/streamvbyte.hpp

@@ -32,6 +32,8 @@ class StreamVByteBlockCodec: public BlockCodec {
   public:
     constexpr static std::string_view name = "block_streamvbyte";
 
+    virtual ~StreamVByteBlockCodec() = default;
+
     void encode(uint32_t const* in, uint32_t sum_of_values, size_t n, std::vector<uint8_t>& out)
         const override;
     uint8_t const*

include/pisa/codec/varint_g8iu.hpp

@@ -22,6 +22,8 @@ class VarintG8IUBlockCodec: public BlockCodec {
   public:
     constexpr static std::string_view name = "block_varintg8iu";
 
+    virtual ~VarintG8IUBlockCodec() = default;
+
     void encode(uint32_t const* in, uint32_t sum_of_values, size_t n, std::vector<uint8_t>& out)
         const override;
     uint8_t const*

include/pisa/codec/varintgb.hpp

@@ -242,6 +242,8 @@ class VarintGbBlockCodec: public BlockCodec {
   public:
     constexpr static std::string_view name = "block_varintgb";
 
+    virtual ~VarintGbBlockCodec() = default;
+
     void encode(uint32_t const* in, uint32_t sum_of_values, size_t n, std::vector<uint8_t>& out)
         const override;
     uint8_t const*