[Bug] Group tab content not loading

[irvinm]

Abstract

4.0.24 breaks loading of the tabs under group-tab.html

Steps to reproduce

1. Start Firefox with clean profile.
2. Install TST.
3. Create group-tab.html
4. See that loading spinner never stops and tab information never displays
5. Notice error in console

Expected result

List of children under the group-tab are displayed on group-tab.html

Actual result

Spinner never finishes

Environment

• Platform (OS): Windows 11
• Version of Firefox: 132.0.1
• Version (or revision) of Tree Style Tab: 4.0.24

[Rhialto]

+1. Also happens here. Another operating system (NetBSD) and Firefox version, also not a fresh install but my heavily used one. But the symptoms are the same.

[johnbwang]

I think something related is also happening with get-tree API call. When I call that, I get the error Error: tab.favIconUrl is undefined.

[piroor]

Sorry it is my fault. The regression is made from an external library and the problem should be fixed with commits piroor/webextensions-lib-tab-favicon-helper@7400c97 and 6503b60 .

[irvinm]

Fix looks good. Thanks!