Feature/sink kafka click #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jice36
force-pushed
the
feature/sink_kafka_click
branch
from
9e41564 to
5f26d84
Compare
dalogutk
reviewed
Jul 23, 2024
source/generator/kafka/kafka.go
Outdated
| ) | ||
|
|
||
| func init() { | ||
| pipelaner.RegisterGenerator("kafka", &Kafka{}) |
There was a problem hiding this comment.
Это мы получается автоматом регистрируем кафку для всех будущих реализаций пайплайнов (включая того же агента, где она никак не используется). Я бы всё же утащил это в темплейт и явно регистрировал в модуле fx, чтобы потом не искать по коду, где и что мы добавили в глобальный стейт на этапе init().
dalogutk
reviewed
Jul 24, 2024
dalogutk
approved these changes
Jul 25, 2024
jice36
force-pushed
the
feature/sink_kafka_click
branch
from
4fd2464 to
56c8c75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.