-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #84
base: master
Are you sure you want to change the base?
Conversation
Status on getting this merged? There's an issue deploying to Cloud Functions if you have a dependency on ts-mocha currently, due to the Appears to have been fixed by what I assume is the CF team. Still, I think it would be a good idea to get these dependencies updated, so issues like that don't come back. |
Thanks for sharing the feedback @larssn, have you tested the build from this branch to make sure it's working as expected? |
Alright, so here's how I tested it:
Seems to work |
Thank you for testing @larssn. @piotrwitek The only detail is that we would have to release a major version with this since we may break for users that don't have |
When the PR will be merged? |
@stenneepro I can update it and test next week. But feel free to contribute earlier if you can. Also, for curiosity are you setting any problem because of ts-mocha when trying to upgrade to TyeScript 5? As it is a dev dependency I don't expect it to prevent you from upgrading your application. |
@felipeplets |
Hey @felipeplets, let me know when it's ready for release I could make an npm RC release to make users testing easier. |
Update the project to run with the latest dev dependencies and remove all
npm audit
vulnerabilities.