Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Refactor TransactionId #11952

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jan 15, 2025

No description provided.

@emeroad emeroad added this to the 3.1.0 milestone Jan 15, 2025
@emeroad emeroad force-pushed the #noissue_txid branch 5 times, most recently from 391ca79 to 9c4b180 Compare January 15, 2025 07:54
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 55.12821% with 35 lines in your changes missing coverage. Please review.

Project coverage is 35.03%. Comparing base (096987d) to head (8727b5b).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...inpoint/common/profiler/util/TransactionUIdV4.java 0.00% 11 Missing ⚠️
...pinpoint/common/profiler/util/TransactionIdV1.java 57.14% 8 Missing and 1 partial ⚠️
...p/pinpoint/profiler/context/id/DefaultTraceId.java 70.00% 3 Missing ⚠️
...int/profiler/context/id/DefaultTraceIdFactory.java 50.00% 3 Missing ⚠️
...ler/context/grpc/mapper/TraceIdMapStructUtils.java 77.77% 1 Missing and 1 partial ⚠️
...tor/handler/grpc/GrpcExceptionMetaDataHandler.java 0.00% 2 Missing ⚠️
...ercorp/pinpoint/profiler/name/AgentIdResolver.java 0.00% 1 Missing ⚠️
...orp/pinpoint/common/profiler/name/Base64Utils.java 83.33% 1 Missing ⚠️
.../pinpoint/common/profiler/util/TransactionUId.java 0.00% 1 Missing ⚠️
...orp/pinpoint/web/calltree/span/LinkedCallTree.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11952      +/-   ##
============================================
- Coverage     35.04%   35.03%   -0.02%     
  Complexity    10967    10967              
============================================
  Files          3823     3826       +3     
  Lines         91706    91718      +12     
  Branches       9700     9697       -3     
============================================
- Hits          32142    32134       -8     
- Misses        56899    56917      +18     
- Partials       2665     2667       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad merged commit c8a7016 into pinpoint-apm:master Jan 20, 2025
3 checks passed
@emeroad emeroad deleted the #noissue_txid branch January 22, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant