Support building vector index with django_tidb>=5.0.1 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
breezewish
reviewed
Oct 25, 2024
| embedding = VectorField(dimensions=3, db_comment="hnsw(distance=cosine)") | ||
| class Meta: | ||
| indexes = [ | ||
| VectorIndex(L2Distance("embedding"), name='idx_l2'), |
There was a problem hiding this comment.
Is it possible to omit the name?
There was a problem hiding this comment.
No, according to the django.db.models.Index, the user must set the name for an expression index in django
https://github.com/django/django/blob/69bf08e3a32492998871eb91ad84b3c8d8117180/django/db/models/indexes.py#L47-L48
Signed-off-by: JaySon-Huang <tshent@qq.com>
breezewish
approved these changes
Nov 5, 2024
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
changed the title
|
@wd0517 PTAL |
wd0517
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on the django-tidb update: pingcap/django-tidb#67
Update the example of using django with vector-index: