This repository was archived by the owner on Jul 24, 2024. It is now read-only.
log_restore: refactor write and ingest logic. (#645) #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/lgtm |
|
/rebuild |
overvenus
reviewed
Mar 5, 2021
tests/config/tikv.toml
Outdated
Comment on lines
19
to
20
| [cdc] | ||
| hibernate-regions-compatible=false |
…ot/br into release-4.0-d87292ca02cb
|
/run-all-tests |
glorv
reviewed
Mar 10, 2021
| @@ -103,6 +103,7 @@ run_sql "DROP DATABASE ${DB}_DDL1" | |||
| run_sql "DROP DATABASE ${DB}_DDL2" | |||
|
|
|||
| # restore full | |||
| export GO_FAILPOINTS='github.com/pingcap/tidb-lightning/lightning/backend/local/FailIngestMeta=return("notleader")' | |||
There was a problem hiding this comment.
Suggested change
| export GO_FAILPOINTS='github.com/pingcap/tidb-lightning/lightning/backend/local/FailIngestMeta=return("notleader")' | |
| export GO_FAILPOINTS='github.com/pingcap/br/pkg/lightning/backend/FailIngestMeta=return("notleader")' |
| @@ -126,6 +127,7 @@ if [ "$row_count" -ne "0" ]; then | |||
| echo "TEST: [$TEST_NAME] fail on ts range test." | |||
| fi | |||
|
|
|||
| export GO_FAILPOINTS='github.com/pingcap/tidb-lightning/lightning/backend/local/FailIngestMeta=return("epochnotmatch")' | |||
|
@ti-srebot: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@3pointer Do we still need to cherry-pick this PR to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #645 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr https://github.com/pingcap/br/pull/729After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Both Lightning and BR have a similar logic. write and ingest kv as well as retry policy. This abstract Ingest method for BR and Lightning easy to use.
What is changed and how it works?
Ingestser.Check List
Tests
Related changes
Release Note