New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use `replaceAll` instead of `replace` with a regex #80

Merged

wesleytodd merged 1 commit into pillarjs:master from Phillip9587:replace-all

Feb 10, 2025

Contributor

Phillip9587 commented Feb 6, 2025

Replaced String.prototype.replace with a regex with String.prototype.replaceAll for:

Double spaces (/\x20{2}/g)
Newlines (/\n/g)

Why?

replaceAll is more efficient for direct string replacements
Reduces regex overhead

wesleytodd approved these changes

View reviewed changes

UlisesGascon approved these changes

View reviewed changes

bjohansebas approved these changes

View reviewed changes


          refactor: use replaceAll instead of replace with a regex

501197f

wesleytodd force-pushed the replace-all branch from 9ca5acd to 501197f Compare

February 10, 2025 18:23

wesleytodd merged commit 59a45ca into pillarjs:master

8 checks passed

wesleytodd mentioned this pull request

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet