Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace setHeaders function with optimized inline header setting #74

Merged
merged 1 commit into from
Feb 10, 2025
Merged

refactor: replace setHeaders function with optimized inline header setting #74

merged 1 commit into from
Feb 10, 2025

Conversation

Phillip9587
Copy link
Contributor

Replaced the setHeaders function with a loop that sets headers directly using Object.entries. This change eliminates the need for the separate setHeaders function.

wesleytodd
wesleytodd approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the kinds of changes I wish we had some benchmarks around. That said, I think we should land this today so we can release it and get it into the next express v5 release. We can figure out perf after that.

@wesleytodd wesleytodd merged commit 91e7957 into pillarjs:master Feb 10, 2025
8 checks passed
@wesleytodd wesleytodd mentioned this pull request Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleytodd wesleytodd wesleytodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phillip9587 @wesleytodd