Skip to content

Commit

Permalink
fix: replace setHeaders function with optimized inline header setting (
Browse files Browse the repository at this point in the history
  • Loading branch information
Phillip9587 authored Feb 10, 2025
1 parent 59a45ca commit 91e7957
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 21 deletions.
1 change: 1 addition & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ unreleased
* remove unnecessary devDependency `readable-stream`
* refactor: use object spread to copy error headers
* refactor: use replaceAll instead of replace with a regex
* refactor: replace setHeaders function with optimized inline header setting

v2.0.0 / 2024-09-02
==================
Expand Down
24 changes: 3 additions & 21 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,9 @@ function send (req, res, status, headers, message) {
res.removeHeader('Content-Range')

// response headers
setHeaders(res, headers)
for (const [key, value] of Object.entries(headers ?? {})) {
res.setHeader(key, value)
}

// security headers
res.setHeader('Content-Security-Policy', "default-src 'none'")
Expand Down Expand Up @@ -289,23 +291,3 @@ function send (req, res, status, headers, message) {
onFinished(req, write)
req.resume()
}

/**
* Set response headers from an object.
*
* @param {OutgoingMessage} res
* @param {object} headers
* @private
*/

function setHeaders (res, headers) {
if (!headers) {
return
}

var keys = Object.keys(headers)
for (var i = 0; i < keys.length; i++) {
var key = keys[i]
res.setHeader(key, headers[key])
}
}

0 comments on commit 91e7957

Please sign in to comment.