Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgspec struct derivative updates #525

Merged
merged 4 commits into from
Jun 27, 2023
Merged

msgspec struct derivative updates #525

merged 4 commits into from
Jun 27, 2023

Conversation

goodboy
Copy link
Contributor

@goodboy goodboy commented Jun 20, 2023

Ran into some weird .data.types.Struct.__annotations__ behavior while workin on #520 so ended up digging and finding the new msgspec.structs API(s) and instead re-implemented our type-casting methods using that.

More or less just a super simple delegation patch in the end 🥳

@goodboy goodboy requested a review from guilledk June 20, 2023 23:07
@goodboy goodboy added dependencies we are the dependent, or are you? data-layer real-time and historical data processing and storage labels Jun 20, 2023
@goodboy goodboy force-pushed the msgspec_struct_updates branch from b22ac20 to ae8358a Compare June 27, 2023 17:32
@goodboy goodboy requested a review from ebisu4 June 27, 2023 17:38
Copy link
Contributor

@ebisu4 ebisu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ebisu4 ebisu4 merged commit a12b008 into master Jun 27, 2023
@ebisu4 ebisu4 deleted the msgspec_struct_updates branch June 27, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-layer real-time and historical data processing and storage dependencies we are the dependent, or are you?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants