Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checkbox for database.DBexport #3214

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

jacklul
Copy link
Contributor

@jacklul jacklul commented Feb 17, 2025

Small thing - maybe it was missed or is not yet being used in FTL config...?

What does this PR aim to accomplish?:

Remove checkbox for non-existent config key database.DBexport introduced in 74baa97, it seems to never ended up being used as database.maxDBdays=0 disables the database anyway (as description states).
It does not seem to exist in FTL config.

image
image

How does this PR accomplish the above?:

Removes the whole div for the checkbox section and updates data-configkeys attribute.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Jack'lul <jacklulcat@gmail.com>
@rdwebdesign
Copy link
Member

maybe it was missed or is not yet being used in FTL config...?

It was missed.
We removed the option from FTL, but it was forgotten here.

@yubiuser yubiuser merged commit 5c6be28 into pi-hole:development Feb 17, 2025
7 checks passed
@jacklul jacklul deleted the remove-dbexport-checkbox branch February 17, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants