Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify status text if a reply was received for clarify #3203

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 30, 2025

What does this implement/fix?

Following on pi-hole/FTL#2169 I propose to rename the text for forwarded queries we received a reply for. The rationale is that this may not always be 100% exact as Pi-hole may have forwarded the query to multiple servers to check if which of the configured upstreams is the fastest. Pi-hole will then only mention the server which replied first. The same holds true in case users manually added all-servers. The change highlights that the shown record is based on the reply from the given server.

grafik


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER merged commit 8e239ec into development Jan 30, 2025
10 checks passed
@DL6ER DL6ER deleted the tweak/forwarded branch January 30, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants