Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the GH token to tests #169

Closed
asgrim opened this issue Jan 2, 2025 · 2 comments · Fixed by #171 or #174
Closed

Pass the GH token to tests #169

asgrim opened this issue Jan 2, 2025 · 2 comments · Fixed by #171 or #174
Assignees
Labels
bug Something isn't working
Milestone

Comments

@asgrim
Copy link
Collaborator

asgrim commented Jan 2, 2025

Occasionally, tests will fail because we are using GH API without an auth token. I suspect making sure the GITHUB_TOKEN in CI will eliminate the issue.

https://github.com/php/pie/actions/runs/12572758302/job/35045103222?pr=166

There was 1 error:

1) Php\PieIntegrationTest\Downloading\GithubPackageReleaseAssetsTest::testDeterminingReleaseAssetUrlForWindows
Composer\Downloader\TransportException: The "https://api.github.com/repos/asgrim/example-pie-extension/releases/tags/2.0.2" file could not be downloaded (HTTP/2 403 ):
{"message":"API rate limit exceeded for 13.91.71.16. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"htt...

D:\a\pie\pie\src\Downloading\GithubPackageReleaseAssets.php:80
D:\a\pie\pie\src\Downloading\GithubPackageReleaseAssets.php:38
D:\a\pie\pie\test\integration\Downloading\GithubPackageReleaseAssetsTest.php:68
@asgrim asgrim added the bug Something isn't working label Jan 2, 2025
@asgrim asgrim self-assigned this Jan 3, 2025
@asgrim asgrim modified the milestones: 0.5.0, 0.6.0 Jan 3, 2025
@asgrim
Copy link
Collaborator Author

asgrim commented Jan 9, 2025

@Bellangelo
Copy link
Contributor

Hi @asgrim, I think I figured out why your fix didn't work originally. Please check: #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants