Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FFI Parsing of Pointer Declaration Lists #17794

Open
wants to merge 2 commits into
base: PHP-8.3
Choose a base branch
from

Conversation

davnotdev
Copy link

struct MyStruct {
    uint8_t** a, *b, c;
};

When a struct is defined in this form, the "base type" of a, b, and c is uint8_t**, so a will be uint8_t**, b will be uint8_t***, and c will be uint8_t**. This PR fixes the issue and adds a test case for it.

@bwoebi
Copy link
Member

bwoebi commented Feb 14, 2025

This file is generated from ext/ffi/ffi.g, so you should fix that one too.

But thanks for fixing and the test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants