fix for #2

package.json

@@ -1,6 +1,6 @@
 {
   "name": "pgb-cli",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "nodeJS CLI to PhoneGap Build",
   "keywords": [
     "PhoneGap",

src/commands/helpers/wait.js

@@ -10,7 +10,7 @@ module.exports = (app) => {
       clearInterval(pollInt)
       clearInterval(printInt)
 
-      if (app.error !== {} && pgb.opts.exitcode) {
+      if (Object.keys(app.error).length > 0 && pgb.opts.exitcode) {
         reject(new Error())
       } else if (app.package) {
         resolve(app)

test/commands/helpers/wait.js

@@ -20,19 +20,19 @@ describe('progress', () => {
   })
 
   test('should resolve with app if already completed', () => {
-    return wait({id: 12, package: 'com.example', status: {}, completed: true})
+    return wait({id: 12, package: 'com.example', status: {}, error: {}, completed: true})
       .then((app) => {
-        expect(app).toEqual({id: 12, package: 'com.example', status: {}, completed: true})
+        expect(app).toEqual({id: 12, package: 'com.example', status: {}, error: {}, completed: true})
         expect(pgb.api.getApp).not.toBeCalled()
         expect(pgb.api.getStatus).not.toBeCalled()
       })
   })
 
   test('should resolve with app if exit', () => {
     pgb.opts.exit = true
-    return wait({id: 12, package: 'com.example', status: {}, completed: true})
+    return wait({id: 12, package: 'com.example', status: {}, error: {}, completed: true})
       .then((app) => {
-        expect(app).toEqual({id: 12, package: 'com.example', status: {}, completed: true})
+        expect(app).toEqual({id: 12, package: 'com.example', status: {}, error: {}, completed: true})
         expect(pgb.api.getApp).not.toBeCalled()
         expect(pgb.api.getStatus).not.toBeCalled()
       })
@@ -50,6 +50,17 @@ describe('progress', () => {
       })
   })
 
+  test('should not reject if exitcode and a successful build', (done) => {
+    pgb.opts.exitcode = true
+    return wait({id: 12, package: 'com.example', status: {}, error: { }, completed: true})
+      .then((app) => {
+        expect(app).toEqual({id: 12, package: 'com.example', status: {}, error: { }, completed: true})
+        expect(pgb.api.getApp).not.toBeCalled()
+        expect(pgb.api.getStatus).not.toBeCalled()
+        expect(stdout.flush().stderr).toHaveLength(1)
+      })
+  })
+
   test('should not reject if not exitcode and a failed build', () => {
     pgb.opts.exitcode = false
     return wait({id: 12, package: 'com.example', status: {}, error: { android: 'bad' }, completed: true})