Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alist ordering #51

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Fix alist ordering #51

merged 2 commits into from
Nov 23, 2020

Conversation

samuel-jimenez
Copy link
Contributor

Restore order of alist to original JSON string.

@samuel-jimenez
Fix alist ordering
33d32d2 
Restore order of alist to original JSON string
@samuel-jimenez
Copy link
Contributor Author

Fix for #61.

@phmarek
Copy link
Owner

phmarek commented Nov 13, 2020

What about a plist?

Please add test cases so that all 3 variants are checked, with at least 2 values each.

Thanks

@samuel-jimenez
Copy link
Contributor Author

Tests added. Hashes are unordered, so I added duplicate values into the tests.

@phmarek phmarek merged commit d8a0d33 into phmarek:master Nov 23, 2020
@phmarek
Copy link
Owner

phmarek commented Nov 23, 2020

  1. Please rebase your changes to the current version before sending a PR!
  2. Don't override the configuration, else tests break upon a second run - always bind them locally only.
  3. Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuel-jimenez @phmarek