Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Experiment or Model" ABSwitch requires common-code description work. #74

Closed
pixelzoom opened this issue Nov 5, 2024 · 5 comments
Closed

Comments

@pixelzoom
Copy link
Contributor

Related to #67 and phetsims/scenery-phet#880 (comment) ...

There is still work to be done on accessibleName for ABSwitch. And that currently blocks MOTHA 1.0.

@pixelzoom pixelzoom changed the title "Experiment or Model" ABSwitch requires common-code work. "Experiment or Model" ABSwitch requires common-code description work. Nov 5, 2024
@pixelzoom
Copy link
Contributor Author

@jessegreenberg did the development work in phetsims/scenery-phet#880, I reviewed the work. Currently assigned to @terracoda to verify that the implementation matches the design expectations.

@terracoda
Copy link

terracoda commented Nov 12, 2024

From 880#issuecomment

I tested MacOS 14.5 Sonoma with VoiceOver, and I think the AB Switch works great.

Sounds good in Chrome, too. Tested with Version 129.0.6668.90 (Official Build) (arm64).

I would love a dev version to try it out with a screen reader user. I'll ask on slack.

@terracoda
Copy link

terracoda commented Nov 12, 2024

@pixelzoom, I verified the AB Switch in MotHA with VoiceOver. I think this issue is unblocked.

@terracoda
Copy link

Is it ok to close this issue?

@pixelzoom
Copy link
Contributor Author

Thanks @terracoda - closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants