Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timers should keep running if the browser/tab is closed #1

Open
crittermike opened this issue Jul 22, 2014 · 3 comments
Open

Timers should keep running if the browser/tab is closed #1

crittermike opened this issue Jul 22, 2014 · 3 comments

Comments

@crittermike
Copy link
Contributor

This could be done by putting start time into localStorage when a timer is started, and deleting it when stopped, so that when the page is first loaded, if any tasks/times exist in localStorage, we know that that's an actively running timer, and should preset it with the correct amount of time and start it.

@crittermike
Copy link
Contributor Author

This has been started in the feature/persistenttimers branch. It saves entries with running timers persistently, but getting them to start back up again on page load with the correct amount of time isn't super simple since that's not how the timers were built to work, so I'm temporarily halting work on this until I can find out if more people are interested in it.

@grayside
Copy link

grayside commented Aug 4, 2014

I think it's valuable to restore it as a completed time entry, message indicating it had been in progress for extra sauce. That way if you start the timer but close the browser without saving you don't entirely lose what you were doing.

@crittermike
Copy link
Contributor Author

I'm hoping that the "close your browser and lose everything" thing won't happen much in practice since you'll have to confirm this popup in the process, but I still see your point, and restoring it as completed would be a bit easier than continuing the timer as if it had never stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants