Rewrite packed file parser with finite state machines #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14
This PR rewrites the packed file parser using finite state machines. The current implementation uses a stateful approach. The new implementation makes the parser easier to read and maintain.
Using the following shell script, I did some real-world tests to compare the
pkglite unpack
output directories (one or multiple) from this implementation and the existing implementation.compare.sh
They are identical.