#16489 - Remove usage of 2nd argument of apcu_fetch() function
#16495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niden
requested changes
Jan 6, 2024
| @@ -208,7 +208,7 @@ class Apcu extends AbstractAdapter | |||
| */ | |||
| protected function doGet(string key) | |||
| { | |||
| return this->phpApcuFetch(this->getPrefixedKey(key)); | |||
| return apcu_fetch(this->getPrefixedKey(key)); | |||
There was a problem hiding this comment.
Let's keep the phpApcuFetch. It is helpful when mocking in tests.
|
Closing after talking with Jeckerson : merging the duplicate one: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Thanks