Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model::toArray added parameter to ignore getters #16491

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

rudiservo
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
Added parameter to Model::toArray to ignore getters in order not to break serialize.

Thanks

@niden
Copy link
Member

niden commented Jan 4, 2024

@rudiservo Thank you for this. Can you please update the changelog also?

@rudiservo rudiservo force-pushed the i16490-model-toarray-serialize branch from a77b135 to 48d7102 Compare January 4, 2024 17:48
@niden niden merged commit 7212ba0 into phalcon:5.0.x Jan 4, 2024
34 checks passed
@niden
Copy link
Member

niden commented Jan 4, 2024

Thank you @rudiservo

@apoca
Copy link

apoca commented Jan 9, 2024

Hi guys,

First of all, thank you for your support and quick response.

When can we have this released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants