Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16461 numericality spaces #16462

Merged
merged 17 commits into from
Nov 6, 2023
Merged

T16461 numericality spaces #16462

merged 17 commits into from
Nov 6, 2023

Conversation

niden
Copy link
Member

@niden niden commented Nov 6, 2023

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Filter\Validation\Validator\Numericality to return false when input has spaces

Thanks

@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Nov 6, 2023
@niden niden requested a review from Jeckerson November 6, 2023 17:10
@niden niden self-assigned this Nov 6, 2023
@niden niden merged commit 4331f83 into phalcon:5.0.x Nov 6, 2023
@niden niden deleted the T16461-numericality-spaces branch November 6, 2023 17:28
@niden niden mentioned this pull request Nov 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @Jeckerson