Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subtle bug in main preventing some error handling #2

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

danielrparks
Copy link
Contributor

Using short variable declarations starting at cmd/qrc2zip/qrc2zip.go:74 shadows err, which causes any errors reported by DoRaw to be lost.

Jank like this is why I'm not a big fan of go 😆

Copy link
Owner

@pgaskin pgaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@pgaskin pgaskin merged commit aa2fe41 into pgaskin:master Dec 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants