Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support GoogleDrive #167

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

support GoogleDrive #167

wants to merge 3 commits into from

Conversation

tomtastic
Copy link

@tomtastic tomtastic requested a review from pgaskin as a code owner August 22, 2024 17:01
@lorenzolewis
Copy link

Have tested this fork on my Kobo Clara Color and it's working like a charm. The only things that were a bit difficult were spotting that the config needed to be modified that's mentioned in the linked comment above.

pgaskin
pgaskin requested changes Nov 28, 2024
View reviewed changes
Copy link
Owner

@pgaskin pgaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delayed review.

Looks good overall, but can you update the documentation and rename the action to gdrive for consistency?

@tomtastic
Copy link
Author

Renamed, but haven't compiled to check it's all still working.
I've added the config documentation and a short blurb about what to put in the Kobo eReader.conf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgaskin pgaskin pgaskin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomtastic @lorenzolewis @pgaskin