Code Quality Fixes #71
Conversation
…to action and return value is not used
…hp and template-functions.php
…owance in composer.json
removed unused globals fixed code style fixed phpdoc
…ng in widgets.php
… in entry-share.php
… in entry-share.php
| <?php printf( __( '%1$s', 'autonomie' ), $categories_list ); ?> | ||
| <?php | ||
| // translators: %1$s Category list in HTML. | ||
| printf( __( '%1$s', 'autonomie' ), $categories_list ); |
There was a problem hiding this comment.
@pfefferle Why did you use the translation here in the first place?
| <?php printf( __( '%1$s', 'autonomie' ), $tags_list ); ?> | ||
| <?php | ||
| // translators: %1$s Tag list in HTML. | ||
| printf( __( '%1$s', 'autonomie' ), $tags_list ); |
| @@ -470,7 +470,7 @@ function autonomie_comment( $comment, $args, $depth ) { | |||
| $GLOBALS['comment'] = $comment; | |||
| ?> | |||
| <li <?php comment_class(); ?> id="li-comment-<?php comment_ID(); ?>"> | |||
| <article id="comment-<?php comment_ID(); ?>" class="comment <?php $comment->comment_type; ?>" itemprop="comment" itemscope itemtype="https://schema.org/Comment"> | |||
| <article id="comment-<?php comment_ID(); ?>" class="comment <?php echo $comment->comment_type; ?>" itemprop="comment" itemscope itemtype="https://schema.org/Comment"> | |||
There was a problem hiding this comment.
@pfefferle Review here, this echo was missing before, please verify that this has no sideeffects, alternatively we can remove the output.
| /* translators: | ||
| %1$s: number of comments, mind to add this if your language uses singular for more than just n=1 | ||
| %2$s: post title | ||
| */ | ||
| _n( | ||
| 'One thought on “%2$s”', // phpcs:ignore WordPress.WP.I18n.MissingSingularPlaceholder -- Translator instructions added. |
There was a problem hiding this comment.
phpcs: WordPress.WP.I18n.MissingSingularPlaceholder: Missing singular placeholder, needed for some languages. See https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
The phpcs error here noted that the placeholder must be added, since slavic and some other languages have multiple singulars, I assume by adding a more precise translators comment, this should be covered.
|
@pfefferle I'm ready with the code style fixes and review. |
This PR includes Code Style, PHPdoc and other code quality fixes.
Pushes with just phpcbf are marked as such.
Besides a few marked places not output should be altered.