Handle SERVER_ERROR from Memcached #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grcooper
force-pushed
the
grcooper/server-error-handling
branch
2 times, most recently
from
5d9776c to
b597dfa
Compare
grcooper
force-pushed
the
grcooper/server-error-handling
branch
from
b597dfa to
8d45b9b
Compare
|
This looks good can you update the changelog, https://github.com/petergoldstein/dalli/blob/main/CHANGELOG.md if you have a good link to where it is mentioned in the memcached spec that would be nice, but I know memcached docs are all being updated and moving at the moment. |
danmayer
requested changes
Feb 1, 2025
danmayer
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the Memcached spec, SERVER_ERROR is a valid value to return, alongside the error message. This only seems to be valid for the Meta/Text protocols.
I have added support so things like Envoy that return SERVER_ERROR will be handled correctly and raised as an appropriate error.
I also added the
debuggem to:developmentand:testsince it is very useful to be able to add things like breakpoints while debugging.