Add host_to_name_map option to Dalli::Protocol::ConnectionManager #1005
Conversation
philister
force-pushed
the
custom_server_name
branch
from
25d9bf0 to
33ba022
Compare
There was a problem hiding this comment.
This name method is buried in the library behind a collection of private methods. Ie to fetch it I believe you have to do things like use the send method? So I am curious as to what you want to do with "tuning the ring-continuum", as that is locked inside of Dalli itself generally.
c = Dalli::Client.new
c.send(:ring).servers.name # needing to do send is a code smell
I also know it's used in stats and version as well, but if you are returning this data in your app I assume you have some kind of name to server mapping that already exists and could map the results as needed?
I just don't want to add more complexity to the top-level options if unnecessary.
| @@ -45,7 +47,13 @@ def name | |||
| if socket_type == :unix | |||
There was a problem hiding this comment.
Why are we not also doing this for unix sockets?
| "#{hostname}:#{port}" | ||
| name = "#{hostname}:#{port}" | ||
|
|
||
| if options[:host_to_name_map][name].nil? |
There was a problem hiding this comment.
This can be simplified to:
options[:host_to_name_map][name] || name
New config-parameter:
host_to_name_mapa hash mapping "host:port" to a name. Useful for providing more descriptive names or tuning the ring-continuum
e.g.
client1
{ 'localhost:11211' => 'memcached1', 'mem2.cach.ed' => 'memcached2'}client2
{ 'localhost:11211' => 'memcached2', 'mem1.cach.ed' => 'memcached1'}For a consistent calculation of which key can be found on which server, the config must also be the same on all clients. Previously, this was only possible if all memcached servers were accessible at the same address on all clients.
However, you may want or be able to reach the memcache servers from different clients only via different addresses (local vs public vs docker vs dns, etc)